8000 feat: Implement grafana-operator Dashboard and Folder CRD health checks by afarbos · Pull Request #22493 · argoproj/argo-cd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Implement grafana-operator Dashboard and Folder CRD health checks #22493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

afarbos
Copy link
Contributor
@afarbos afarbos commented Mar 26, 2025

Following the example of #20294

Supported CRDs:

  • grafana.integreatly.org/GrafanaDashboard
  • grafana.integreatly.org/GrafanaFolder

This is a way to increase current coverage of grafana operator heath with common use cases of dashboards but also folders.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@afarbos afarbos requested a review from a team as a code owner March 26, 2025 15:43
Copy link
bunnyshell bot commented Mar 26, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@afarbos afarbos force-pushed the af/GDGF branch 4 times, most recently from abd7218 to 8ee5418 Compare March 26, 2025 16:31
@afarbos
Copy link
Contributor Author
afarbos commented Mar 26, 2025

Changes validated with go test -v ./util/lua/

Copy link
codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@3f3ac06). Learn more about missing BASE report.
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #22493   +/-   ##
=========================================
  Coverage          ?   59.96%           
=========================================
  Files             ?      344           
  Lines             ?    57751           
  Branches          ?        0           
=========================================
  Hits              ?    34631           
  Misses            ?    20345           
  Partials          ?     2775           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Arnaud Farbos <afarbos@nvidia.com>
@afarbos
Copy link
Contributor Author
afarbos commented May 8, 2025

@crenshaw-dev I just saw you added component:health-check label, I did also see the build was failing for unrelated reason. I rebased now everything looks green. Let me know if you have any comment.

Copy link
Member
@agaudreault agaudreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agaudreault agaudreault merged commit 5a3a104 into argoproj:master May 9, 2025
27 checks passed
LyhengTep pushed a commit to LyhengTep/argo-cd that referenced this pull request May 10, 2025
…ks (argoproj#22493)

Signed-off-by: Arnaud Farbos <afarbos@nvidia.com>
ranakan19 pushed a commit to ranakan19/argo-cd that referenced this pull request May 20, 2025
…ks (argoproj#22493)

Signed-off-by: Arnaud Farbos <afarbos@nvidia.com>
Signed-off-by: Kanika Rana <krana@redhat.com>
olivergondza pushed a commit to olivergondza/argo-cd that referenced this pull request May 20, 2025
…ks (argoproj#22493)

Signed-off-by: Arnaud Farbos <afarbos@nvidia.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
tylerrosnett pushed a commit to StateFarmIns/argo-cd that referenced this pull request May 27, 2025
…ks (argoproj#22493)

Signed-off-by: Arnaud Farbos <afarbos@nvidia.com>
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
…ks (argoproj#22493)

Signed-off-by: Arnaud Farbos <afarbos@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0