-
Notifications
You must be signed in to change notification settings - Fork 6.1k
feat: Implement grafana-operator Dashboard and Folder CRD health checks #22493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
abd7218
to
8ee5418
Compare
Changes validated with |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22493 +/- ##
=========================================
Coverage ? 59.96%
=========================================
Files ? 344
Lines ? 57751
Branches ? 0
=========================================
Hits ? 34631
Misses ? 20345
Partials ? 2775 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Arnaud Farbos <afarbos@nvidia.com>
@crenshaw-dev I just saw you added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ks (argoproj#22493) Signed-off-by: Arnaud Farbos <afarbos@nvidia.com>
…ks (argoproj#22493) Signed-off-by: Arnaud Farbos <afarbos@nvidia.com> Signed-off-by: Kanika Rana <krana@redhat.com>
…ks (argoproj#22493) Signed-off-by: Arnaud Farbos <afarbos@nvidia.com> Signed-off-by: Oliver Gondža <ogondza@gmail.com>
…ks (argoproj#22493) Signed-off-by: Arnaud Farbos <afarbos@nvidia.com>
…ks (argoproj#22493) Signed-off-by: Arnaud Farbos <afarbos@nvidia.com>
Following the example of #20294
Supported CRDs:
This is a way to increase current coverage of grafana operator heath with common use cases of dashboards but also folders.
Checklist: