8000 fix(hydrator): don't get cluster or API versions for hydrator (#21985) by crenshaw-dev · Pull Request #22038 · argoproj/argo-cd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(hydrator): don't get cluster or API versions for hydrator (#21985) #22038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2025
Merged

fix(hydrator): don't get cluster or API versions for hydrator (#21985) #22038

merged 1 commit into from
Feb 26, 2025

Conversation

crenshaw-dev
Copy link
Member

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@crenshaw-dev
fix(hydrator): don't get cluster or API versions for hydrator (argopr…
8cc94fe 
…oj#21985)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev requested a review from a team as a code owner February 26, 2025 19:55
@crenshaw-dev crenshaw-dev mentioned this pull request Feb 26, 2025
Merged
@crenshaw-dev crenshaw-dev merged commit d79185a into argoproj:release-2.14 Feb 26, 2025
20 of 21 checks passed
@crenshaw-dev crenshaw-dev deleted the fix-hydrator-cluster-access-2.14 branch February 26, 2025 20:33
@codecov Codecov
Copy link
codecov bot commented Feb 26, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 55.15%. Comparing base (8f925c6) to head (8cc94fe).
R 8B2A eport is 50 commits behind head on release-2.14.

Files with missing lines Patch % Lines
controller/state.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           release-2.14   #22038      +/-   ##
================================================
- Coverage         55.16%   55.15%   -0.02%     
================================================
  Files               338      338              
  Lines             57216    57217       +1     
================================================
- Hits              31562    31556       -6     
- Misses            22944    22956      +12     
+ Partials           2710     2705       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumstead rumstead rumstead approved these changes

@agaudreault agaudreault agaudreault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crenshaw-dev @rumstead @agaudreault
0