fix: accidental v3 imports #22068
Merged
fix: accidental v3 imports #22068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
agaudreault
approved these changes
Feb 27, 2025
rumstead
approved these changes
Feb 27, 2025
|
the helm issue affecting the code gen here :-/ |
|
@rumstead yep plus the usual version mismatch. Ignoring it for now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-2.14 #22068 +/- ##
================================================
+ Coverage 53.26% 55.18% +1.91%
================================================
Files 338 338
Lines 57227 57227
================================================
+ Hits 30483 31581 +1098
+ Misses 24082 22934 -1148
- Partials 2662 2712 +50 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix accidental imports of v3 package introduced by https://github.com/argoproj/argo-cd/pull/21901/files#r1974216989