fix: Change applicationset generate HTTP method to avoid route conflicts (cherry-pick #20758) #21299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cts (#20758) * Change applicationset generate HTTP method to avoid route conflicts Signed-off-by: Amit Oren <amit@coralogix.com> * Update server/applicationset/applicationset.proto Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Amit Oren <github@amitoren.dev> * Codegen Signed-off-by: Amit Oren <amit@coralogix.com> --------- Signed-off-by: Amit Oren <amit@coralogix.com> Signed-off-by: Amit Oren <github@amitoren.dev> Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
agaudreault
approved these changes
Dec 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-2.14 #21299 +/- ##
================================================
+ Coverage 55.14% 55.19% +0.05%
================================================
Files 338 338
Lines 57167 57167
================================================
+ Hits 31525 31554 +29
+ Misses 22941 22909 -32
- Partials 2701 2704 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix: Change applicationset generate HTTP method to avoid route conflicts (#20758)
Signed-off-by: Amit Oren amit@coralogix.com
Co-authored-by: Alexandre Gaudreault alexandre_gaudreault@intuit.com
Signed-off-by: Amit Oren github@amitoren.dev
Signed-off-by: Amit Oren amit@coralogix.com
Signed-off-by: Amit Oren amit@coralogix.com
Signed-off-by: Amit Oren github@amitoren.dev
Co-authored-by: Alexandre Gaudreault alexandre_gaudreault@intuit.com