8000 feat(actions): parametrized actions to scale workloads (#15505) by ratulbasak · Pull Request #20097 · argoproj/argo-cd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(actions): parametrized actions to scale workloads (#15505) #20097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 81 commits into from
May 8, 2025
Merged

feat(actions): parametrized actions to scale workloads (#15505) #20097

merged 81 commits into from
May 8, 2025

Conversation

ratulbasak
Copy link
Contributor
@ratulbasak ratulbasak commented Sep 25, 2024 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

This feature request is about an extension of the argocd resource actions feature to support inputs on those actions (like the replica count if you have a custom action to scale replicas: enhancement proposal

@ratulbasak ratulbasak requested a review from a team as a code owner September 25, 2024 08:08
@bunnyshell Bunnyshell
Copy link
bunnyshell bot commented Sep 25, 2024 •
edited
Loading

❗ Preview Environment delete from Bunnyshell failed

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to try again to remove the environment

@bunnyshell Bunnyshell
Copy link
bunnyshell bot commented Sep 25, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

ratulbasak and others added 16 commits September 25, 2024 10:49
@ratulbasak
15505 added scale feature
4782eaa 
Signed-off-by: ratulbasak <ratulbasak93@gmail.com>
@js3692 @ratulbasak
fix(ui): add state parameter in the pkce flow (argoproj#17235)
53b0ce5 
* Add state to pkce flow

Signed-off-by: Jungho Son <js3692@users.noreply.github.com>

* Call unset

Signed-off-by: Jungho Son <js3692@users.noreply.github.com>

---------

Signed-off-by: Jungho Son <js3692@users.noreply.github.com>
Signed-off-by: ratulbasak <ratulbasak93@gmail.com>
@morey-tech @ratulbasak
docs: add project to repo creds examples (argoproj#20057)
88af191 
* docs: add link to example repo creds yaml

Signed-off-by: Nicholas Morey <nicholas@morey.tech>

* docs: add project to repo creds examples

Signed-off-by: Nicholas Morey <nicholas@morey.tech>

---------

Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Signed-off-by: ratulbasak <ratulbasak93@gmail.com>
@4llan @ratulbasak
docs: fix paragraph in "User Guide/Kustomize" (argoproj#20053)
fba32af 
Without the extra line break, the paragraph was rendered as part of the Kustomize application manifest.

Signed-off-by: Allan M. de Azevedo <4llan@users.noreply.github.com>
Signed-off-by: ratulbasak <ratulbasak93@gmail.com>
@jsoref @ratulbasak
ci: Allow forks to opt-in for codeql (argoproj#19996)
5ab655b 
Signed-off-by: Josh Soref <jsoref@gmail.com>
Signed-off-by: ratulbasak <ratulbasak93@gmail.com>
@Jack-R-lantern @ratulbasak
feat: option to disable writing k8s events(argoproj#18205) (argoproj#…
8b91837 
…18441)

* feat: option to disable writing k8s events

optioned to write logs for k8s events.
Each is passed as an environment variable and defaults to true,
disabling it requires explicitly setting the option to false.

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>

* feat: option to disable writing k8s events

fix unit test
- application_test
- applicationset_test
- project_test
- appcontroller_tes
- audit_logger_test

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>

* rebase

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>

---------

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>
Signed-off-by: ratulbasak <ratulbasak93@gmail.com>
@linghaoSu @ratulbasak
feat(ui): move graphs by dragging mouse in app resource tree view (ar…
1bcaeec 
…goproj#18025) (argoproj#20009)

Signed-off-by: linghaoSu <linghao.su@daocloud.io>
Signed-off-by: ratulbasak <ratulbasak93@gmail.com>
@dependabot @ratulbasak
chore(deps): bump google.golang.org/grpc from 1.66.2 to 1.67.0 (argop…
4b3bf9b 
…roj#20059)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.66.2 to 1.67.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.66.2...v1.67.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: ratulbasak <ratulbasak93@gmail.com>
@nueavv @ratulbasak
fix: corrected --roleARN to --role-arn as per updated CLI option (arg…
92ba40d 
…oproj#20065)

Signed-off-by: nueavv <nuguni@kakao.com>
Signed-off-by: ratulbasak <ratulbasak93@gmail.com>
@nitishfy @ratulbasak
fix: fix broken link (argoproj#20070)
c6a5bac 
* fix broken link

Signed-off-by: nitishfy <justnitish06@gmail.com>

* fix broken link

Signed-off-by: nitishfy <justnitish06@gmail.com>

---------

Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: ratulbasak <ratulbasak93@gmail.com>
@dependabot @ratulbasak
chore(deps): bump go.uber.org/automaxprocs from 1.5.3 to 1.6.0 (argop…
8000
d17f845 
…roj#20068)

Signed-off-by: ratulbasak <ratulbasak93@gmail.com>
@github-actions @ratulbasak
[Bot] docs: Update Snyk reports (argoproj#20052)
2731116 
Signed-off-by: CI <ci@argoproj.com>
Co-authored-by: CI <ci@argoproj.com>
Signed-off-by: ratulbasak <ratulbasak93@gmail.com>
@jsolana @crenshaw-dev @ratulbasak
feat: transmit manifest-generate-path resources to the cmp-server for…
4ee39e5 
… plugin-based applications (argoproj#19209)

* chore: transmit manifest-generate-path resources to the cmp-server for plugin-based applications
Signed-off-by: Javier Solana <javier.solana@cabify.com>

* use SecureJoin
Signed-off-by: Javier Solana <javier.solana@cabify.com>

* make cmp manifests generation using manifest generate path annotation configurable by environment variable
Signed-off-by: Javier Solana <javier.solana@cabify.com>

* fix missing doc running codegen-local
Signed-off-by: Javier Solana <javier.solana@cabify.com>

* set reposerver.plugin.enable.manifests.generation.using.annotations false by default
Signed-off-by: Javier Solana <javier.solana@cabify.com>

* define ARGOCD_REPO_SERVER_PLUGIN_ENABLE_GENERATE_MANIFESTS_USING_MANIFEST_GENERATE_PATHS_ANNOTATION properly
Signed-off-by: Javier Solana <javier.solana@cabify.com>

* define ARGOCD_REPO_SERVER_PLUGIN_ENABLE_GENERATE_MANIFESTS_USING_MANIFEST_GENERATE_PATHS_ANNOTATION properly
Signed-off-by: Javier Solana <javier.solana@cabify.com>

* Fix conflict
Signed-off-by: Javier Solana <javier.solana@cabify.com>

* autogenerate install manifests
Signed-off-by: Javier Solana <javier.solana@cabify.com>

* add note about common root path calculation for manifest paths annotation
Signed-off-by: Javier Solana <javier.solana@cabify.com>

* log common root path calculated
Signed-off-by: Javier Solana <javier.solana@cabify.com>

* app path must be the lower common path
Signed-off-by: Javier Solana <javier.solana@cabify.com>

* tweaks

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Javier Solana <javier.solana@cabify.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: ratulbasak <ratulbasak93@gmail.com>
@ratulbasak
15505 removed console log
c8c448f 
Signed-off-by: ratulbasak <ratulbasak93@gmail.com>
@ratulbasak
15505 updated scale regex starting from 0
b941ef0 
Signed-off-by: ratulbasak <ratulbasak93@gmail.com>
@chengfang @ratulbasak
fix: CVE-2024-45296 Backtracking regular expressions cause ReDoS by u…
f864d68 
…pgrading path-to-regexp from 1.8.0 to 1.9.0 (argoproj#20087)

Signed-off-by: Cheng Fang <cfang@redhat.com>
Signed-off-by: ratulbasak <ratulbasak93@gmail.com>
@ratulbasak ratulbasak force-pushed the 15505-scale-resources-in-ui branch from a6efc06 to f864d68 Compare September 25, 2024 08:50
@ratulbasak ratulbasak requested review from a team as code owners September 25, 2024 08:50
@codecov Codecov
Copy link
codecov bot commented Sep 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.73171% with 12 lines in your changes missing coverage. Please review.

Project coverage is 59.90%. Comparing base (9a738b2) to head (d6e2701).
Report is 261 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/admin/settings.go 33.33% 11 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #20097      +/-   ##
==========================================
+ Coverage   56.08%   59.90%   +3.81%     
==========================================
  Files         343      344       +1     
  Lines       57546    57752     +206     
==========================================
+ Hits        32275    34596    +2321     
+ Misses      22627    20393    -2234     
- Partials     2644     2763     +119

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jsoref
jsoref reviewed Sep 25, 2024
View reviewed changes
@ratulbasak
Ratul Basak ratulbasak93@gmail.com Updated Lua scripts
0fe0602 
Signed-off-by: ratulbasak <ratulbasak93@gmail.com>
@ratulbasak
Merge branch '15505-scale-resources-in-ui' of github.com:ratulbasak/a…
d4934f5 
…rgo-cd into 15505-scale-resources-in-ui
mubarak-j
mubarak-j reviewed Sep 26, 2024
View reviewed changes
@ratulbasak
Copy link
Contributor Author

Hello @crenshaw-dev, please look into this PR - an enhancement feature: #15505 which was already approved about a year ago. Could you please help me on how to move forward?

@murmur76
Copy link

Review please, thank you.
@crenshaw-dev @jsoref @todaywasawesome @reggie-k @mubarak-j @agaudreault

@ratulbasak
Ratul Basak ratulbasak93@gmail.com updated
e8a1aa0 
Signed-off-by: ratulbasak <ratulbasak93@gmail.com>
nitishfy
nitishfy reviewed May 5, 2025
View reviewed changes
Copy link
Member
@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things here:

  1. Can you update the PR description to provide details about which issue is this PR fixing?
  2. I see a lot of commits from different authors (> 70). Are these intended or was there a problem when trying to rebase or perform other git operation? It looks like those commits might have come from performing a git operation.

@ratulbasak
Copy link
Contributor Author

Few things here:

  1. Can you update the PR description to provide details about which issue is this PR fixing?
  2. I see a lot of commits from different authors (> 70). Are these intended or was there a problem when trying to rebase or perform other git operation? It looks like those commits might have come from performing a git operation.

I do not know about these commits tbh, they were added while rebasing.

agaudreault
agaudreault requested changes May 5, 2025
View reviewed changes
Copy link
Member
@agaudreault agaudreault left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. few little things that should require a codegen after, then I think this can be merged and improvements can be done in follow-up PRs if necessary. (a lot of comment/discussion on this PR and it starts to be hard to track)

agaudreault and others added 4 commits May 6, 2025 09:46
@agaudreault
remove unused fields
d8d392e 
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@ratulbasak
Ratul Basak ratulbasak93@gmail.com updated
ba91086 
Signed-off-by: ratulbasak <ratulbasak93@gmail.com>
@agaudreault
move validation to lua actions
ae973f1 
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@agaudreault
Merge remote-tracking branch 'refs/remotes/ratulbasak/15505-scale-res…
1afdd2f 
…ources-in-ui' into 15505-scale-resources-in-ui

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@agaudreault
Copy link
Member
agaudreault commented May 6, 2025 •
edited
Loading

@ratulbasak I pushed some change to move the validation to the lua script and fix the default value that was not working anymore. The reason behind the change is because we would need to add every kind of possible validation parameters such as min, max, regexp, etc.

UI could be improved in future PRs to use the "type" and display different kind of input field, but the backend API should not contain information specific for the validation (already done by Kubernetes)

image image

agaudreault added 5 commits May 6, 2025 17:36
@agaudreault
fix UI errors
dcbb81d 
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@agaudreault
remove value declaration in discovery
23c5d10 
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@agaudreault
rename to replicas
048e447 
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@agaudreault
lint
0d0ec78 
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@agaudreault
fix tests
d6e2701 
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
agaudreault
agaudreault approved these changes May 7, 2025
View reviewed changes
Copy link
Member
@agaudreault agaudreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agaudreault agaudreault enabled auto-merge (squash) May 7, 2025 16:50
@ratulbasak
Copy link
Contributor Author

@ratulbasak I pushed some change to move the validation to the lua script and fix the default value that was not working anymore. The reason behind the change is because we would need to add every kind of possible validation parameters such as min, max, regexp, etc.

UI could be improved in future PRs to use the "type" and display different kind of input field, but the backend API should not contain information specific for the validation (already done by Kubernetes)

image image

Super!

reggie-k
reggie-k approved these changes May 8, 2025
View reviewed changes
Copy link
Member
@reggie-k reggie-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for the patience with this @ratulbasak!

@agaudreault agaudreault merged commit 111da39 into argoproj:master May 8, 2025
39 of 41 checks passed
This was referenced May 8, 2025
Closed
Closed
LyhengTep pushed a commit to LyhengTep/argo-cd that referenced this pull request May 10, 2025
@ratulbasak @agaudreault @LyhengTep
feat(actions): parametrized actions to scale workloads (argoproj#15505)…
7056f98 
… (argoproj#20097)

Signed-off-by: Ratul Basak <ratulbasak93@gmail.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
ranakan19 pushed a commit to ranakan19/argo-cd that referenced this pull request May 20, 2025
@ratulbasak @agaudreault @ranakan19
feat(actions): parametrized actions to scale workloads (argoproj#15505)…
af429cb 
… (argoproj#20097)

Signed-off-by: Ratul Basak <ratulbasak93@gmail.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Kanika Rana <krana@redhat.com>
olivergondza pushed a commit to olivergondza/argo-cd that referenced this pull request May 20, 2025
@ratulbasak @agaudreault @olivergondza
feat(actions): parametrized actions to scale workloads (argoproj#15505)…
e020399 
… (argoproj#20097)

Signed-off-by: Ratul Basak <ratulbasak93@gmail.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
tylerrosnett pushed a commit to StateFarmIns/argo-cd that referenced this pull request May 27, 2025
@ratulbasak @agaudreault @tylerrosnett
feat(actions): parametrized actions to scale workloads (argoproj#15505)…
26cef00 
… (argoproj#20097)

Signed-off-by: Ratul Basak <ratulbasak93@gmail.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@crenshaw-dev crenshaw-dev mentioned this pull request Jun 3, 2025
Closed
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
@ratulbasak @agaudreault @chansuke
feat(actions): parametrized actions to scale workloads (argoproj#15505)…
693aa50 
… (argoproj#20097)

Signed-off-by: Ratul Basak <ratulbasak93@gmail.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev left review comments

@jsoref jsoref jsoref left review comments

@todaywasawesome todaywasawesome todaywasawesome left review comments

@murmur76 murmur76 murmur76 left review comments

@mubarak-j mubarak-j mubarak-j left review comments

@nitishfy nitishfy nitishfy left review comments

@graham-kang graham-kang graham-kang left review comments

@reggie-k reggie-k reggie-k approved these changes

@agaudreault agaudreault agaudreault approved these changes

Assignees
No one assigned
Labels
for-release-blog-3-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0