8000 fix: cleanup tempdir when errors occur in Helm chart extraction by ilia-medvedev-codefresh · Pull Request #19861 · argoproj/argo-cd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: cleanup tempdir when errors occur in Helm chart extraction #19861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2024
Merged

fix: cleanup tempdir when errors occur in Helm chart extraction #19861

merged 2 commits into from
Sep 17, 2024

Conversation

ilia-medvedev-codefresh
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@ilia-medvedev-codefresh
fix: cleanup tempdir when errors occur in Helm chart extraction
8280375 
Signed-off-by: Ilia Medvedev <ilia.medvedev@codefresh.io>
@ilia-medvedev-codefresh ilia-medvedev-codefresh requested a review from a team as a code owner September 10, 2024 06:32
@bunnyshell Bunnyshell
Copy link
bunnyshell bot commented Sep 10, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link
bunnyshell bot commented Sep 10, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

nitishfy
nitishfy reviewed Sep 10, 2024
View reviewed changes
nitishfy
nitishfy reviewed Sep 10, 2024
View reviewed changes
nitishfy
nitishfy suggested changes Sep 10, 2024
View reviewed changes
Copy link
Member
@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments and look for other places in the same file where we need to cleanup the tempdir (eg. here)

@codecov Codecov
Copy link
codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 55.81%. Comparing base (ebbd3d1) to head (621bbba).
Report is 468 commits behind head on master.

Files with missing lines Patch % Lines
util/helm/client.go 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #19861      +/-   ##
==========================================
- Coverage   55.82%   55.81%   -0.01%     
==========================================
  Files         320      320              
  Lines       44368    44374       +6     
==========================================
- Hits        24768    24767       -1     
- Misses      17037    17043       +6     
- Partials     2563     2564       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blakepettersson
blakepettersson approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member
@blakepettersson blakepettersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

todaywasawesome
todaywasawesome approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor
@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great fix!

@todaywasawesome
Merge branch 'master' into fix/extract-chart-cleanup-tempdir-on-error
621bbba 
Signed-off-by: Dan Garfield <dan@codefresh.io>
@todaywasawesome todaywasawesome enabled auto-merge (squash) September 11, 2024 22:09
@todaywasawesome todaywasawesome merged commit 20f9719 into argoproj:master Sep 17, 2024
27 of 28 checks passed
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
@ilia-medvedev-codefresh @todaywasawesome @adriananeci
fix: cleanup tempdir when errors occur in Helm chart extraction (argo…
1b0a1f6 
…proj#19861)

Fixed merge conflicts.

Signed-off-by: Ilia Medvedev <ilia.medvedev@codefresh.io>
Signed-off-by: Dan Garfield <dan@codefresh.io>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakepettersson blakepettersson blakepettersson approved these changes

@todaywasawesome todaywasawesome todaywasawesome approved these changes

@christianh814 christianh814 christianh814 approved these changes

@gdsoumya gdsoumya gdsoumya approved these changes

@nitishfy nitishfy nitishfy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ilia-medvedev-codefresh @blakepettersson @todaywasawesome @christianh814 @gdsoumya @nitishfy
0