Supply resourceVersion to watch request to prevent reading of stale cache #1612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4fd32da to
209ad4b
Compare
209ad4b to
a937131
Compare
Codecov Report
@@ Coverage Diff @@
## master #1612 +/- ##
=========================================
+ Coverage 32.33% 32.4% +0.06%
=========================================
Files 70 70
Lines 11214 11225 +11
=========================================
+ Hits 3626 3637 +11
+ Misses 7059 7055 -4
- Partials 529 533 +4
Continue to review full report at Codecov.
|
jessesuen
added a commit
that referenced
this pull request
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1605
Our Application Watch API will now perform a list followed by a watch, and supply the resource version to the K8s watch request. This guarantees we do not return stale/inconsistent application data after some previous mutation (e.g. Sync operation).
NOTE: List + Watch is the same technique that
kubectl get -wuses.