8000 Fixed Responsiveness for Hero and Conversation by Vaibhav91one · Pull Request #1194 · arc53/DocsGPT · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed Responsiveness for Hero and Conversation #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixed Responsiveness for Hero and Conversation #1194

wants to merge 1 commit into from

Conversation

Vaibhav91one
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fixes for Hero and Conversation component.

  • Why was this change needed? (You can also link to an open issue here)
    The UI was buggy when the sidebar closes for mobile screens.
    🐛 Bug Report: Mobile Responsive #1192

  • Other information:
    image

@vercel Vercel
Copy link
vercel bot commented Oct 2, 2024

@Vaibhav91one is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link
vercel bot commented Oct 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 7:28pm

ManishMadan2882
ManishMadan2882 reviewed Oct 3, 2024
View reviewed changes
Copy link
Collaborator
@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Vaibhav91one

Reviewed the changes, have few points:

  1. The input box width planned to be wider as per the current UI design.
  2. Tagline under the input box is supposed to be hidden in the mobile devices
  3. The responsiveness issue in Hero and Conversations was recently solved in this PR, if it is specific to some tablets please mention.

Thank you!

@Vaibhav91one
Copy link
Contributor Author

Hi @ManishMadan2882

  • Yes, I think the Height issue is fixed on the official website,
  • About the tagline I think it looks better in mobile also, if done correctly.
  • Lastly, When sidebar closes this is how it looks, which i think is a little off.

Ultimately, Its your repo your rules. 😊

Official:
image

From my branch:
image

@ManishMadan2882
Copy link
Collaborator

Hi @Vaibhav91one
Agree with the 3rd point, but we need to make sure that it doesn't affect the desktop version.
It looks like a issue in Tablet screens, also the tagline will be good to have in tab.
Thanks!

8000

@Vaibhav91one
Copy link
Contributor Author

Hi @Vaibhav91one Agree with the 3rd point, but we need to make sure that it doesn't affect the desktop version. It looks like a issue in Tablet screens, also the tagline will be good to have in tab. Thanks!

HI @ManishMadan2882, So, the changes that will be done are done in previous PR in hero and conversation components. I will submit a new PR with the updated branch. Works?

@ManishMadan2882
Copy link
Collaborator

Absolutely @Vaibhav91one .

@shelar1423
Copy link
Collaborator

Hey @Vaibhav91one , there is also a chance we would request you to fix as it aligns with the query bar issue.

image

Currently when we close the side bar and ask a query the query bar and the generated text arent aligned as shown in the picture.
So we need to fix this and make sure they are aligned.

@Vaibhav91one
Copy link
Contributor Author

Hey @Vaibhav91one , there is also a chance we would request you to fix as it aligns with the query bar issue.

image

Currently when we close the side bar and ask a query the query bar and the generated text arent aligned as shown in the picture. So we need to fix this and make sure they are aligned.

@shelar1423 , You mean the Answer and the ouput right?

@dartpain
Copy link
Contributor
dartpain commented Oct 7, 2024

I think it looks like after sidebar is closed, the input box is not really centered, and that makes it mismatched with the output. Basically all things need to be aligned well here

@Vaibhav91one
Copy link
Contributor Author

Please find the below PR for the changes.
Pull Request

@ManishMadan2882 ManishMadan2882 mentioned this pull request Oct 9, 2024
Closed
@dartpain dartpain closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManishMadan2882 ManishMadan2882 ManishMadan2882 left review comments

Assignees
No one assigned
Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vaibhav91one @ManishMadan2882 @shelar1423 @dartpain
0