DAO-43 Multichain support - WIP #1562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use use-wallet 0.9.0 * remove unnecessary dependency * fix the CI error @toruslabs/fetch-node-details@2.7.0 for node version too old * Re-order templates (#1558) * detect network change * use injected instead of provided connector, as provided connector is a hack to around web3.js overrides * switch welcome page content base on network * more reactive network changes * fix error on missing networkType * eth node and ipfs settings by network * getAppLocator by network type Co-authored-by: Rekard0 <5880388+Rekard0@users.noreply.github.com>
* temporary use --network-concurrency 1, to be removed once use-wallet 0.9.0 is published.
* connectors redesigned for multichain
* only show network settings on mainnet
* refactor and attempt to fix websocket leaks * fix connection error on socket disconnect web3 * eslint fixed * update aragon wrapper Co-authored-by: yuetloo <contact@yuetloo.com>
|
|
* connectors redesigned for multichain * eslint problems fixed * multi localstorage * update multi localstorage * update aragon.js wrapper * eslint fixed
novaknole
reviewed
Aug 4, 2021
| @@ -79,7 +80,7 @@ function getExtendedRepos(appInstanceGroups, repos) { | |||
| return { | |||
| ...repo, | |||
| // Use latest version’s assets | |||
| baseUrl: repoBaseUrl(repo.appId, repo.latestVersion), | |||
| baseUrl: repoBaseUrl(repo.appId, repo.latestVersion, networkType), | |||
There was a problem hiding this comment.
Do we really need to pass networkType ? as In I can see it gets used for app locator and for getting ipfs gateway. Do we have different ipfs gateways for different networks ? Don't see the point of having different ones.
Do we need it for appLocator as well ?
There was a problem hiding this comment.
do you know what appLocator is exactly? is there environment variable settings for the current rinkeby and mainnet settings for APP_LOCATOR?
From these lines and the unit test, the mainnet and rinkeby might have different app locator for finance/voting app??
https://github.com/aragon/client/blob/master/src/app-locator.js#L72-L77
* fix load org error on network switch * ipfs settings is network agnostic * code review comment * remove mainnet from network type
fix bug that caused create dao to freeze
* show network only for mainnet * replace logging with sentry with console.log * remove sentry * add newline * remove obsolete .env.enc file
* fix deployment error due to missing wallet * redirect to home on network change * fix lint error
* use networkName from use-wallet * remove neteworkType.js * revert network type changes for notification service * update comment
* connectors redesigned for multichain * eslint problems fixed * add govern migration page * fix lint error * add address field and refactoring * add govern migration script call * add govern migration handler * remove network type * update yarn.lock * eslint fixed * eslint fixed * eslint fixed * eslint fixed * fix nullish operator * fixed eslint * fixed eslint Co-authored-by: yuetloo <contact@yuetloo.com>
* add mumbai * migration + multichain * eslint fixed * eslint fixed
* add mumbai * fix matic symbol * eslint fixed
…/client into feature/DAO-43-multichain
* add mumbai * add discover app check * eslint fixed * fix missing dependency in hook
…/client into feature/DAO-43-multichain
* add mumbai * fix network name on copy missing
…/client into feature/DAO-43-multichain
* add mumbai * add template removal for unavailable templates * eslint fixed'
…/client into feature/DAO-43-multichain
* add mumbai * update aragon ui
* page ui updates * update ui order * add transaction pannel * clean up * fix lint * add descripting to transaction * remove unneccessary dep Co-authored-by: Giorgi Lagidze <glagh14@freeuni.edu.ge>
* fix no connection issue and eslint warning * remove unneccessary comment Co-authored-by: Giorgi Lagidze <glagh14@freeuni.edu.ge>
…/client into feature/DAO-43-multichain
* add mumbai * govern migration restriction * fix eslint
…/client into feature/DAO-43-multichain
* pass network to init wrapper * from network to type + use wallet update Co-authored-by: Giorgi Lagidze <glagh14@freeuni.edu.ge>
* cleanup code * reset isListening status on network switch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.