fix: clean core types #4500
Open
fix: clean core types #4500
+1,041
−1,264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging to
|
|
As you've now noticed by the failing tests, these generics are all used for type inference on the SDK. They provide the necessary context to augment the |
|
As far as I'm aware, TypeScript doesn't have something like Rust's |
8000
|
Ah, I only tested the main project, I need to look at those then too. |
|
also want to add that sometimes typescript failing is a good thing: I’ll have to look into this better though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last week I noticed, while working on the tests, that the types could be better.
I looked at them, yesterday, and today. And am finding a lot of room for improvement.
There are many type parameters which are either not used, or in some cases incorrect.
There are also many “wrapper” types, which can be inlined, resulting in less code and shorter “stack” traces.
I am sharing this PR before it becomes bigger. It is already bigger than would be nice. But, there is still lot more to do. And it’s all tiny commits. So separate PRs would take a while to merge. I can do that though.