8000 Add convenience methods to create BuildingBlockDescriptor for default cases · Issue #5 · archifacts/archifacts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add convenience methods to create BuildingBlockDescriptor for default cases #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nils-christian opened this issue Aug 7, 2021 · 1 comment · Fixed by #23
Closed

Add convenience methods to create BuildingBlockDescriptor for default cases #5

nils-christian opened this issue Aug 7, 2021 · 1 comment · Fixed by #23
Labels
clarification-needed Needs to be discussed before implementation enhancement New feature or request

Comments

@nils-christian
Copy link
Contributor

This is certainly always a difficult topic, but it would be nice to have some convenience methods to create BuildingBlockDescriptors for some default cases. While writing descriptors for my application I noticed that I can reduce most of them to three cases:

  • JavaClass ends with a certain name
  • JavaClass is assignable to a certain class
  • JavaClass is annotated with a certain annotation

I wrote the methods as part of a helper class, but they could (theoretically) be part of the BuildingBlockDescriptor interface as well.

applicationBuilder.addBuildingBlockDescriptor( BuildingBlockDescriptorHelper.forAssignableTo( BuildingBlockType.of( "Repository" ), Repository.class ) );
applicationBuilder.addBuildingBlockDescriptor( BuildingBlockDescriptorHelper.forSimpleNameEndingWith( BuildingBlockType.of( "Projection" ), "Projection" ) );
@OLibutzki OLibutzki added enhancement New feature or request clarification-needed Needs to be discussed before implementation labels Aug 9, 2021
@nils-christian nils-christian mentioned this issue Aug 11, 2021
Open
@nils-christian
Copy link
Contributor Author

I made a suggestion for this issue in form of a PR (#23).

@OLibutzki OLibutzki linked a pull request Aug 11, 2021 that will close this issue
[#5] Add convenience methods to create BuildingBlockDescriptor for de… #23
Merged
OLibutzki added a commit that referenced this issue Aug 13, 2021
@OLibutzki
Merge pull request #23 from nils-christian/#5
800a4c6 
Fixes #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarification-needed Needs to be discussed before implementation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#5] Add convenience methods to create BuildingBlockDescriptor for de…
2 participants
@OLibutzki @nils-christian
0