Money instance creation from a formatted string #16

gauravmak · 2022-03-09T07:45:33Z

This PR adds an additional method to create a money instance from a formatted string.

Changes overview:

New static method fromFormatted() inside the Money class which:
1. Accepts currency and currency configuration overrides (optional)
2. Tries to extract the currency if it is not provided by the user
3. Throws an exception if no currency matches the prefix and suffix of the formatted string
4. Throws an exception if multiple currencies match the prefix and suffix of the formatted string
5. Calls the PriceFormatter::resolve() to get the decimal value
New static method resolve() inside the PriceFormatter class to manage the decimal extraction. A process on formatted string:
1. Removes the prefix and suffix
2. Removes everything other than the number of the decimal separator
3. Replaces decimal formatted string with a . (period) to allow the following float conversion
4. Converts to float and returns the decimal value
New tests inside the MoneyTest class for the new method
Readme updates to inform users about the new method's functionality
Improve code readability by using the pow() PHP function

Closes #1

…ey into from_string_implementation

stancl · 2022-03-09T19:36:52Z

Do you think the method could resolve the currency as well?

It will be ambiguous sometimes (e.g. USD and AUD), but when it's not, it'd be cool if it could infer the currency from the string.

gauravmak · 2022-03-10T06:17:24Z

@stancl Now it extracts the currency from the formatted string.

README.md

src/PriceFormatter.php

Co-authored-by: Samuel Štancl <samuel@archte.ch>

src/PriceFormatter.php

src/Money.php

stancl · 2022-04-05T13:25:44Z

Looks great, thanks!

gauravmak and others added 6 commits March 9, 2022 12:49

refactor: improve code readability

8bdf0d1

feature: money instance creation from a formatted string

38c6326

Fix code style (php-cs-fixer)

01fd16f

fix: make PHPStan happy by protecting against some rare scenarios

77bec6e

Merge branch 'from_string_implementation' of github.com:gauravmak/mon…

2329dcf

…ey into from_string_implementation

Fix code style (php-cs-fixer)

fa337d2

gauravmak added 2 commits March 10, 2022 11:39

feat: extract currency from the formatted string

93aeb2c

fix: no more currency guessing

a8d32a0