8000 feat: Update to go 1.17 by simar7 · Pull Request #1084 · aquasecurity/tracee · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Update to go 1.17 #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
< 8000 /div>
Merged
merged 1 commit into from
Jan 14, 2022
Merged

feat: Update to go 1.17 #1084

merged 1 commit into from
Jan 14, 2022

Conversation

simar7
Copy link
Member
@simar7 simar7 commented Oct 14, 2021

merge this prior to: #1083 and #1082

Signed-off-by: Simar simar@linux.com

@simar7 simar7 self-assigned this Oct 14, 2021
danielpacak
danielpacak suggested changes Oct 18, 2021
View reviewed changes
Copy link
Contributor
@danielpacak danielpacak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but the build is failing on GitHub runner and in my local env with the following error:

$ go build -o dist/tracee-rules
go: updates to go.mod needed; to update it:
	go mod tidy

@danielpacak danielpacak marked this pull request as draft October 18, 2021 12:16
@simar7
Copy link
Member Author
simar7 commented Oct 18, 2021

Overall looks good, but the build is failing on GitHub runner and in my local env with the following error:

$ go build -o dist/tracee-rules
go: updates to go.mod needed; to update it:
	go mod tidy

Hrm, yeah it's strange because locally it fine for me. Let me see what's missing here. But another way would also be to see what difference do you get if you run go mod tidy in your go.mod and go.sum files and push to this branch.

@simar7
Copy link
Member Author
simar7 commented Oct 18, 2021

Overall looks good, but the build is failing on GitHub runner and in my local env with the following error:

$ go build -o dist/tracee-rules
go: updates to go.mod needed; to update it:
	go mod tidy

Hrm, yeah it's strange because locally it fine for me. Let me see what's missing here. But another way would also be to see what difference do you get if you run go mod tidy in your go.mod and go.sum files and push to this branch.

Looks like it figured it out this time.

@yanivagman yanivagman mentioned this pull request Nov 4, 2021
Closed
@grantseltzer
Copy link
Contributor

@simar7 Can you mark this as ready for review? As part of the next release I'd like to upgrade to 1.17

@grantseltzer grantseltzer added this to the v0.6.5 milestone Nov 29, 2021
@simar7 simar7 marked this pull request as ready for review November 30, 2021 00:36
@simar7
Copy link
Member Author
simar7 commented Nov 30, 2021

@simar7 Can you mark this as ready for review? As part of the next release I'd like to upgrade to 1.17

I've marked it ready for review, but please make sure all stakeholders are OK with this change. Last time that was not the case, as communicated offline.

@yanivagman
Copy link
Collaborator

@mtcherni95

@mtcherni95
Copy link
Contributor

It will take some time in order for CNDR team to test if there is any issue with using an updated version of Go.
Maybe, we could push it after 6.5 release?

@grantseltzer
Copy link
Contributor

@mtcherni95 Is there anything about 1.17 you expect to be an issue? What would the testing consist of? Go 1.17 came out in August and I have been compiling/running tracee with it since then without any issue.

@itaysk
Copy link
Collaborator
itaysk commented Dec 1, 2021

maybe dump question, but do you really need to upgrade CNDR just because we now build Tracee with go 1.17?

@mtcherni95
Copy link
Contributor

maybe dump question, but do you really need to upgrade CNDR just because we now build Tracee with go 1.17?

that's the thing - I am not sure about it (I don't think so, but still wanted to test it first). It's in my backlog.

@itaysk
Copy link
Collaborator
itaysk commented Dec 1, 2021

when do you think you'll test it?

@grantseltzer grantseltzer modified the milestones: v0.6.5, v0.6.6 Dec 1, 2021
@mtcherni95 mtcherni95 mentioned this pull request Dec 14, 2021
Merged
@yanivagman
Copy link
Collaborator

@simar7 can you please rebase so we can merge?

@simar7
feat: Upgrade to go 1.17
abdde55 
Signed-off-by: Simar <simar@linux.com>
@simar7 simar7 force-pushed the update-to-go-1.17 branch from a17cb83 to abdde55 Compare January 14, 2022 00:09
@simar7
Copy link
Member Author
simar7 commented Jan 14, 2022

@simar7 can you please rebase so we can merge?

rebased

@danielpacak danielpacak merged commit 98993c4 into aquasecurity:main Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielpacak danielpacak danielpacak approved these changes

@itaysk itaysk Awaiting requested review from itaysk

@yanivagman yanivagman Awaiting requested review from yanivagman

@grantseltzer grantseltzer Awaiting requested review from grantseltzer

Assignees

@simar7 simar7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@simar7 @grantseltzer @yanivagman @mtcherni95 @itaysk @danielpacak
0