Use filepath.WalkDir() to scan for signatures #901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jan0ski please see #893 and rebase to include those changes. |
|
@jan0ski sorry but you'll need to rebase again after #903 |
|
Should be all up to date now. Let me know if anything's missing. |
grantseltzer
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 This PR should address #501 . Only concern I have is that I'm not sure how to test
findGoSigs(), as go signatures were also left out ofTest_getSignatures(). Happy to add that coverage with some guidance!findRegoSigs()andfindGoSigs()to utilizefilepath.WalkDir()to recursively scan for signaturesfindRegoSigs()