8000 tracee-ebpf: add flags support for make test by josedonizetti · Pull Request #879 · aquasecurity/tracee · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

tracee-ebpf: add flags support for make test #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 16, 2021
Merged

tracee-ebpf: add flags support for make test #879

merged 2 commits into from
Aug 16, 2021

Conversation

josedonizetti
Copy link
Contributor

Allowing external flags to go test. This simplify getting coverage reports or running single tests. Eg:

make test GOTEST_FLAGS="-run Test_updateFileSHA"
make test GOTEST_FLAGS="-cover"
...

itaysk
itaysk reviewed Aug 5, 2021
View reviewed changes
Copy link
Collaborator
@itaysk itaysk 8000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea. while we're doing that, do you mind adding the same to the other makefiles?

@josedonizetti
Copy link
Contributor Author

@itaysk I added it to tracee-rules/Makefile, but opted to not change the tracee-rules/benchmark/Makefile which is more specific and already declared flags of its own.

yanivagman
yanivagman approved these changes Aug 15, 2021
View reviewed changes
Copy link
Collaborator
@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itaysk itaysk merged commit cbc56c9 into aquasecurity:main Aug 16, 2021
@josedonizetti josedonizetti deleted the add-gotest-flags branch August 16, 2021 09:32
@josedonizetti josedonizetti restored the add-gotest-flags branch August 16, 2021 09:32
@josedonizetti josedonizetti deleted the add-gotest-flags branch August 16, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itaysk itaysk itaysk left review comments

@yanivagman yanivagman yanivagman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josedonizetti @itaysk @yanivagman
0