Refactor: Remove Rego signature support #4426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7e02458 to
97bf354
Compare
geyslan
approved these changes
Dec 12, 2024
d986657 to
7a2674e
Compare
Closed
This commit removes support for Rego-based signatures in Tracee. Rego signatures, while easier to write than compiled Go signatures, introduced performance overhead. This removal simplifies the Tracee codebase and prepares for the future introduction of Wasm-based signatures, which will offer both improved performance and extended capabilities. In the meantime, users can leverage the following: - **Go-based signatures:** For optimal performance and custom event handling. - **Tracee policies:** For basic event filtering needs, providing a convenient way to define filters directly within the policy. Tracee policies currently address the most common use case for signatures. Future development will focus on expanding Tracee's capabilities to accommodate more advanced scenarios.
This commit removes the 'Verify Signatures' step from the GitHub Actions workflow as it was specifically testing for rego signatures, which are no longer supported in the project.
7a2674e to
345166f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
This PR removes support for Rego-based signatures in Tracee.
Rego signatures, while easier to write than compiled Go signatures, introduced performance overhead. This removal simplifies the Tracee codebase and prepares for the future introduction of Wasm-based signatures, which will offer both improved performance and extended capabilities.
In the meantime, users can leverage the following:
Tracee policies currently address the most common use case for signatures. Future development will focus on expanding Tracee's capabilities to accommodate more advanced scenarios.
2. Explain how to test it
3. Other comments