8000 Fix: Prevent Modal Dropdown Truncation on Mobile by HarshMN2345 · Pull Request #2085 · appwrite/console · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: Prevent Modal Dropdown Truncation on Mobile #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HarshMN2345
Copy link
Member
@HarshMN2345 HarshMN2345 8000 commented Jul 6, 2025

Fix: Prevent Modal Dropdown Truncation on Mobile

Problem

On mobile devices, dropdowns (such as the Columns dropdown in the Adjustments modal) were being truncated or clipped due to the modal’s content area having restricted overflow.

Solution

CSS-only fix:

  • Added a global CSS rule in src/lib/components/confirm.svelte
  • Allows dropdowns and overlays inside modals to overflow the modal content area
  • Ensures dropdowns are fully visible and scrollable on mobile devices

Reverted Changes

  • All previous JavaScript or logic-based changes related to dropdown max-height or mobile-specific handling have been reverted
  • This PR contains only the CSS fix mentioned above

Result

  • Dropdowns inside modals are now fully visible and usable across all devices, including mobile
  • No other logic or structural code was changed
  • This is a minimal and focused fix addressing the truncation issue

Before and After

Screenshot 2025-07-06 144534
Screenshot 2025-07-06 145447

…tent area, preventing them from being clipped or truncated.
@coolify-appwrite-org
Copy link
coolify-appwrite-org bot commented Jul 6, 2025

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2025-07-06 09:36:37 CET

@coolify-appwrite-org
Copy link
coolify-appwrite-org bot commented Jul 6, 2025

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2025-07-06 09:36:36 CET

@HarshMN2345 HarshMN2345 requested a review from Copilot July 6, 2025 09:34
@HarshMN2345 HarshMN2345 self-assigned this Jul 6, 2025
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A CSS-only fix to allow dropdowns and overlays inside modals to overflow their container, preventing truncation on mobile devices.

  • Added a global CSS rule to make modal sections overflow visible
  • Reverted all previous JS/logic-based dropdown size handling
  • Ensures dropdowns are fully visible and scrollable across all devices

@@ -68,3 +68,9 @@
</svelte:fragment>
</Dialog>
</Form>

<style>
:global(dialog section) {
Copy link
Preview
Copilot AI Jul 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The global selector applies to all sections and could unintentionally affect other modals. Consider scoping this rule by adding a specific class or using a more targeted selector.

Suggested change
:global(dialog section) {
.confirm-dialog section {
8000

Copilot uses AI. Check for mistakes.

Comment on lines +73 to +74
:global(dialog section) {
overflow: visible !important;
Copy link
Preview
Copilot AI Jul 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relying on !important can make future CSS maintenance more difficult. If possible, increase selector specificity or refactor existing styles instead of using !important.

Suggested change
:global(dialog section) {
overflow: visible !important;
:global(dialog[data-component="confirm"] section) {
overflow: visible;

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6518
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0