fix: add tooltip on disabled button #2070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR restores a missing tooltip on disabled "Invite" buttons for free-tier organizations with existing members, improving UX by clarifying the upgrade path.
- Wrapped the "Invite" buttons on both the members page and the header in a
Tooltipcomponent. - Added reactive logic (
isFreeWithMembers,isButtonDisabled) to control when the button is disabled and when the tooltip appears. - Imported
Tooltip,BillingPlan, andtierToPlanto drive the tooltip’s conditional content.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/routes/(console)/organization-[organization]/members/+page.svelte | Added imports for Tooltip, BillingPlan, and tierToPlan; introduced reactive statements; wrapped the invite button in Tooltip. |
| src/routes/(console)/organization-[organization]/header.svelte | Wrapped header invite button in Tooltip; updated billing imports to include tierToPlan. |
Comments suppressed due to low confidence (3)
src/routes/(console)/organization-[organization]/members/+page.svelte:47
- Consider adding unit or integration tests for the new tooltip and disable logic (
isFreeWithMembersandisButtonDisabled) to verify that the tooltip only appears on FREE plans with 1+ members.
// Calculate if button should be disabled and tooltip should show
src/routes/(console)/organization-[organization]/header.svelte:123
- The variable
areMembersLimitedis used but not defined or imported, leading to a runtime reference error. Define this reactive boolean or import it from the appropriate store.
<Tooltip disabled={!areMembersLimited} placement="bottom-end">
src/routes/(console)/organization-[organization]/header.svelte:135
- The constant
BillingPlanis referenced here but not imported. Addimport { BillingPlan } from '$lib/constants';to ensure it's available in this file.
{organization?.billingPlan === BillingPlan.FREE
ItzNotABug
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Restore Tooltip for Disabled "Invite" Button on Free Orgs
Problem:
Disabled "Invite" button on free orgs lacked tooltip, leaving users unclear on how to enable it.
Solution:
Added missing tooltip in:
/organization-[org]/membersTooltip Behavior:
"Upgrade to add more members"bottom-end(below, right-aligned)Testing: