fix: undefined errors around billing pages #2078
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1b3c10 to
047cd06
Compare
Because of plansInfo.get(), aggregationBillingPlan was undefined for custom plans since they were not part of the billing.getPlansInfo() result. Instead, use the currentPlan that is already fetched from the parent layout.
047cd06 to
02a6ba9
Compare
When moving to a page without $organization, org is undefined and results in this "undefined (reading 'billingNextInvoiceDate')" error.
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-07-04 04:45:01 CET |
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-07-04 04:45:00 CET |
6c20536 to
1be8ede
Compare
ItzNotABug
reviewed
Jul 4, 2025
ORGANIZATIONS is clearer because it refers to the resource for the dependency. So, any time the ORGANLIZATIONS (list) needs to be refreshed, the this dependency can be invalidated.
ItzNotABug
requested changes
Jul 4, 2025
| @@ -18,7 +18,7 @@ export enum Dependencies { | |||
| INVOICES = 'dependency:invoices', | |||
| ADDRESS = 'dependency:address', | |||
| UPGRADE_PLAN = 'dependency:upgrade_plan', | |||
| CREATE_ORGANIZATION = 'dependency:create_organization', | |||
| ORGANIZATIONS = 'dependency:ORGANIZATIONS', | |||
There was a problem hiding this comment.
Suggested change
| ORGANIZATIONS = 'dependency:ORGANIZATIONS', | |
| ORGANIZATIONS = 'dependency:organizations', |
| @@ -21,6 +21,7 @@ | |||
| }); | |||
| trackEvent(Submit.OrganizationBillingAddressDelete); | |||
| invalidate(Dependencies.ORGANIZATION); | |||
There was a problem hiding this comment.
won't this be invalidated anyway due to Dependencies.ORGANIZATIONS' waterfall?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
currentPlan (which came from the page's aggregationBillingPlan) can be undefined leading to an error like:
leading to a blank page:
This PR changes the page to use the currentPlan from the parent that should already be available.
Also:
Test Plan
Manual test:
Related PRs and Issues
None
Have you read the Contributing Guidelines on issues?
Yes