8000 fix: Adjust markdown lists margin by ichik · Pull Request #40273 · appsmithorg/appsmith · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Adjust markdown lists margin #40273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

fix: Adjust markdown lists margin #40273

merged 1 commit into from
Apr 16, 2025

Conversation

ichik
Copy link
Contributor
@ichik ichik commented Apr 16, 2025 •
edited by github-actions bot
Loading

Description

Prevents overflowing up to hundreds.

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/14489373046
Commit: eb22618
Cypress dashboard.
Tags: @tag.Sanity
Spec:

Wed, 16 Apr 2025 10:10:20 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Style
    • Improved indentation for list items in markdown content for better readability.

@ichik ichik requested a review from a team as a code owner April 16, 2025 09:23
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Apr 16, 2025 •
edited
Loading

Walkthrough

The change updates the CSS styling for list items within markdown content. Specifically, it increases the left margin for both base and nested list items, affecting how lists are indented visually. No other selectors or properties were modified, and there were no changes to exported or public entities.

Changes

File Path Change Summary
app/client/packages/design-system/widgets/src/components/Markdown/src/styles.module.css Increased left margin for li elements and nested li items

Possibly related PRs

Suggested labels

skip-changelog, ok-to-test

Suggested reviewers

  • jsartisan
  • hetunandu

Poem

Lists now march with extra space,
Indented lines in tidy grace.
Markdown shines with margin new,
A subtle shift—now clearer view.
Bullets nest, their order true,
CSS tweaks, and we’re all through!
📝✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.
📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 86c5a77 and eb22618.

📒 Files selected for processing (1)
  • app/client/packages/design-system/widgets/src/components/Markdown/src/styles.module.css (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: client-lint / client-lint
  • GitHub Check: client-unit-tests / client-unit-tests
  • GitHub Check: client-prettier / prettier-check
  • GitHub Check: client-build / client-build
  • GitHub Check: storybook-tests
  • GitHub Check: chromatic-deployment
  • GitHub Check: chromatic-deployment
🔇 Additional comments (2)
app/client/packages/design-system/widgets/src/components/Markdown/src/styles.module.css (2)

82-82: List item margin increased for better layout.

The increased left margin for list items should improve readability and prevent overflow. Looks good!

89-89: Nested list item margin increased.

The extra indentation for nested list items is a sensible adjustment for clarity. No issues here.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Bug Something isn't working label Apr 16, 2025
@ichik ichik added the ok-to-test Required label for CI label Apr 16, 2025
@ichik ichik enabled auto-merge (squash) April 16, 2025 10:10
@ichik ichik merged commit 303a4d8 into release Apr 16, 2025
54 checks passed
@ichik ichik deleted the fix/adjust-list-margin branch April 16, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsartisan jsartisan jsartisan approved these changes

@infinitetrooper infinitetrooper Awaiting requested review from infinitetrooper

Assignees
No one assigned
Labels
Bug Something isn't working ok-to-test Required label for CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ichik @jsartisan
0