Fix flaky testTaskCancel_whenStreaming_andNotSuspended #2355
8000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
approved these changes
Jan 23, 2023
240499a to
3e64930
Compare
Lukasa
reviewed
Jan 23, 2023
| let value = await iterator.next() | ||
|
|
||
| // Sleeping here a bit to make sure we hit the | ||
| try? await Task.sleep(nanoseconds: 500_000) |
There was a problem hiding this comment.
Is 500 microseconds sufficient?
There was a problem hiding this comment.
Changed to 1 ms and 2 ms. That should be enough
# Motivation Currently `testTaskCancel_whenStreaming_andNotSuspended` is flaky since `didTerminate` can be called after the iterator is dropped. Fixes apple#2354 # Modification Let's modify that slightly so we hight the condition we want to hit. # Result No more flaky tests.
3e64930 to
346315c
Compare
Lukasa
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently
testTaskCancel_whenStreaming_andNotSuspendedis flaky sincedidTerminatecan be called after the iterator is dropped. Fixes #2354Modification
Let's modify that slightly so we hight the condition we want to hit.
Result
No more flaky tests.