Update Let Expressions Examples #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because I did not understand what a `Let Expressen` should be and the example code was more confusing as explanatory, I changed the format of the examples a little bit and changed the result. - It should be clear that the example is just one code-line - I tried out the example (`pkl eval...`) and get a little bit different result
holzensp
approved these changes
Oct 14, 2024
holzensp
pushed a commit
to holzensp/pkl
that referenced
this pull request
Oct 14, 2024
Because I did not understand what a `Let Expression` should be and the example code was more confusing as explanatory, I changed the format of the examples a little bit and changed the result. - It should be clear that the example is just one code-line - I tried out the example (`pkl eval...`) and get a little bit different result
holzensp
added a commit
that referenced
this pull request
Oct 16, 2024
Because I did not understand what a `Let Expression` should be and the example code was more confusing as explanatory, I changed the format of the examples a little bit and changed the result. - It should be clear that the example is just one code-line - I tried out the example (`pkl eval...`) and get a little bit different result Co-authored-by: ManuW <ManuW@users.noreply.github.com>
holzensp
added a commit
to holzensp/pkl
that referenced
this pull request
Oct 23, 2024
Because I did not understand what a `Let Expression` should be and the example code was more confusing as explanatory, I changed the format of the examples a little bit and changed the result. - It should be clear that the example is just one code-line - I tried out the example (`pkl eval...`) and get a little bit different result Co-authored-by: ManuW <ManuW@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because I did not understand what a
Let Expressionshould be and the example code was more confusing as explanatory, I changed the format of the examples a little bit and changed the result.pkl eval...) and get a little bit different result