8000 feat(base-driver): Use `markSensitive` to mask password input field value by dprevost-LMI · Pull Request #21118 · appium/appium · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(base-driver): Use markSensitive to mask password input field value #21118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
3 changes: 2 additions & 1 deletion packages/base-driver/lib/express/express-logging.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import '@colors/colors';
import morgan from 'morgan';
import log from './logger';
import {MAX_LOG_BODY_LENGTH} from '../constants';
import {logger} from '@appium/support';

// Copied the morgan compile function over so that cooler formats
// may be configured
Expand Down Expand Up @@ -51,7 +52,7 @@ const startLogFormatter = morgan(
});
} catch {}
}
log.info(requestStartLoggingFormat(tokens, req, res), reqBody.grey);
log.info(requestStartLoggingFormat(tokens, req, res), logger.markSensitive(reqBody.grey));
},
{immediate: true}
);
Expand Down
6 changes: 2 additions & 4 deletions packages/base-driver/lib/jsonwp-proxy/protocol-converter.js