8000 Local Coherence Deflation by rrhodgson · Pull Request #109 · aportelli/Hadrons · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Local Coherence Deflation #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 7, 2023
Merged

Local Coherence Deflation #109

merged 12 commits into from
Apr 7, 2023

Conversation

rrhodgson
Copy link
Contributor

Here is the proposal for the overhaul of the deflation setup and adding the local coherence (coarse) deflation.
Requires Grid PR #426 to be accepted first.

Includes:

  • Eigenpack compressor/decompressor
  • Add coarse deflation
  • Make source casting its own module
  • Combine bathed and non-batched version of modules
  • Removed reloading batched deflation
  • Add batched mixed precision solver

@rrhodgson rrhodgson requested a review from aportelli as a code owner March 21, 2023 12:57
aportelli
aportelli requested changes Apr 5, 2023
View reviewed changes
Copy link
Owner
@aportelli aportelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this is really great, please address the changes below. I will merge in develop once we have more visibility about fixes needed (or not) after Grid's feature/dirichlet merge.

  • please address comments in code
  • please use name_ only for private variables and not function arguments

Hadrons/Modules/MUtilities/EigenPackLCCompress.hpp Outdated
BEGIN_HADRONS_NAMESPACE

/******************************************************************************
* Local coherence Lanczos eigensolver *
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix comment

Hadrons/Modules/MUtilities/EigenPackLCDecompress.hpp Outdated
BEGIN_HADRONS_NAMESPACE

/******************************************************************************
* Local coherence Lanczos eigensolver *
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix comment

@rrhodgson
Copy link
Contributor Author

Thanks for the comments. They should be fixed now.
I also changed the evBatchSize back to 1. It will run exactly the same but gives more verbose debug output

aportelli
aportelli approved these changes Apr 6, 2023
View reviewed changes
Copy link
Owner
@aportelli aportelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! All good

@aportelli aportelli merged commit ad62b01 into aportelli:develop Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aportelli aportelli aportelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rrhodgson @aportelli
0