8000 Fix character encoding issue of template rendering by yisiqi · Pull Request #1747 · apereo/cas · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix character encoding issue of template rendering #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Merged

Fix character encoding issue of template rendering #1747

merged 5 commits into from
May 6, 2016

Conversation

yisiqi
Copy link
Contributor
@yisiqi yisiqi commented May 6, 2016 •
edited
Loading

@mmoayyed Fix encoding issue which mentioned in #1731.

f9779a60-11d6-11e6-8b76-0ca45819b660

@mmoayyed
Copy link
Member
mmoayyed commented May 6, 2016

Before pressing merge, could I ask you to:

  • Reverse the change
  • Find your application.properties file and set spring.thymeleaf.encoding=UTF-8.
  • See what happens

@yisiqi yisiqi closed this May 6, 2016
@yisiqi
Copy link
Contributor Author
yisiqi commented May 6, 2016 •
edited
Loading

@mmoayyed I just tried exactly same as what you said.
But still NOT works.

2016-05-06 11 45 26

@yisiqi yisiqi reopened this May 6, 2016
@mmoayyed
Copy link
Member
mmoayyed commented May 6, 2016

OK, thanks. What you want to do then is:

  1. Add a field to the class of type ThymeleafProperties and autowire it.
  2. Use that field to do: setCharacterEncoding(thymeleafProperties.getCharacterEncoding())

That should work, rather than hardcoding the encoding.

@mmoayyed mmoayyed added this to the 5.0.0 milestone May 6, 2016
@mmoayyed mmoayyed merged commit 3c4a237 into apereo:master May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Internationalization
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yisiqi @mmoayyed
0