Return access token responses in JSON format #1645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Looks good. |
leleuj
added a commit
that referenced
this pull request
Mar 22, 2016
Return access token responses in JSON format
9738
Miccia94
pushed a commit
to Miccia94/gerrit_oauth
that referenced
this pull request
Dec 5, 2022
Add config boolean to use JSON token extraction rather than the regex based extractor for plain text responses. Support for JSON token responses was added in CAS v6.1.0: apereo/cas#1645 Support for plain text seems to have been removed in the same release by this commit: apereo/cas@c9b555386f7e165d98d6616b4294 Default behaviour unchanged to continue to support CAS v5 users. Bug: Issue 16232 Change-Id: I15f195001e5ee823f3832388b23c6b2f2dbb3cd4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1644