fixed serialisation error when persisting TGT since keySet returns non-s... #667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-serializable view - create a copy of the returned set view.
|
What's the exception returned? I think the problem is related to immutable collections, isn't it? In that case, the problem should be fixed by making Kryo able to handle immutable collections. I think we already have a JIRA to upgrade Kryo library version to make that easy. |
|
Agreed with @leleuj We do have an issue here, which should be fixed at the kyro level. |
|
The exception was NotSerializableException and from debugging cas, I found it is caused by non serializable keySet. |
|
Indeed, but it's a too limited fix, which won't work for other immutable collections. I'm closing this PR and will address #495 instead in a few weeks. |
This was referenced Aug 5, 2021
This was referenced Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...erializable view - create a copy of the returned set view.