8000 feat: specify allowed symbols in password generation by cjc7373 · Pull Request #9480 · apecloud/kubeblocks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: specify allowed symbols in password generation #9480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: specify allowed symbols in password generation #9480

wants to merge 3 commits into from

Conversation

cjc7373
Copy link
Contributor
@cjc7373 cjc7373 commented Jun 25, 2025

fix #9458

@cjc7373 cjc7373 added the pick-1.0 Auto cherry-pick to release-1.0 when PR merged label Jun 25, 2025
@apecloud-bot
Copy link
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.0

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Jun 25, 2025
@codecov Codecov
Copy link
codecov bot commented Jun 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 31.81818% with 15 lines in your changes missing coverage. Please review.

Project coverage is 59.71%. Comparing base (1d711bd) to head (a69e900).

Files with missing lines Patch % Lines
pkg/common/password.go 27.77% 13 Missing ⚠️
...ps/cluster/transformer_cluster_sharding_account.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9480      +/-   ##
==========================================
+ Coverage   59.63%   59.71%   +0.08%     
==========================================
  Files         500      500              
  Lines       54384    54380       -4     
==========================================
+ Hits        32431    32474      +43     
+ Misses      19033    18994      -39     
+ Partials     2920     2912       -8
Flag Coverage Δ
unittests 59.71% <31.81%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cjc7373 cjc7373 marked this pull request as ready for review June 25, 2025 08:23
@cjc7373 cjc7373 requested a review from a team as a code owner June 25, 2025 08:23
@cjc7373 cjc7373 requested a review from shanshanying June 25, 2025 08:23
@apecloud-bot apecloud-bot added the approved PR Approved Test label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leon-inf leon-inf leon-inf approved these changes

@shanshanying shanshanying Awaiting requested review from shanshanying

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
approved PR Approved Test pick-1.0 Auto cherry-pick to release-1.0 when PR merged size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Features] Support excluding specific symbols in generated database passwords
3 participants
@cjc7373 @apecloud-bot @leon-inf
0