8000 [SPARK-44316][BUILD] Upgrade Jersey to 2.40 by panbingkun · Pull Request #41874 · apache/spark · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[SPARK-44316][BUILD] Upgrade Jersey to 2.40 #41874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

panbingkun
Copy link
Contributor
@panbingkun panbingkun commented Jul 6, 2023

What changes were proposed in this pull request?

The pr aims to upgrade Jersey from 2.36 to 2.40.

Why are the changes needed?

1.This version adapts to ASM9.5, which is also used by Spark currently
Adopt ASM 9.5

2.Also fix some bugs, eg:
Fix possible NPE in netty client
Get media type fix

3.Security vulnerability fix:
CVE for dependency jackson-databind

4.Full Release Notes:
https://github.com/eclipse-ee4j/jersey/releases/tag/2.40
https://github.com/eclipse-ee4j/jersey/releases/tag/2.39
https://github.com/eclipse-ee4j/jersey/releases/tag/2.38
https://github.com/eclipse-ee4j/jersey/releases/tag/2.37

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA.

@github-actions github-actions bot added the BUILD label Jul 6, 2023
@@ -196,7 +196,11 @@
<datanucleus-core.version>4.1.17</datanucleus-core.version>
<guava.version>14.0.1</guava.version>
<janino.version>3.1.9</janino.version>
<jersey.version>2.36</jersey.version>
<!--
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jersey 3.x only support Java 11+, maybe we can upgrade to 3.x in Spark 4.0 :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good proposal!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for that.

Copy link
Contributor
@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member
@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @panbingkun and all.

@dongjoon-hyun
Copy link
Member

Merged to master for Apache Spark 3.5.0.

ragnarok56 pushed a commit to ragnarok56/spark that referenced this pull request Mar 2, 2024
### What changes were proposed in this pull request?
The pr aims to upgrade Jersey from 2.36 to 2.40.

### Why are the changes needed?
1.This version adapts to ASM9.5, which is also used by Spark currently
[Adopt ASM 9.5](eclipse-ee4j/jersey#5305)

2.Also fix some bugs, eg:
[Fix possible NPE in netty client](eclipse-ee4j/jersey#5330)
[Get media type fix](eclipse-ee4j/jersey#5282)

3.Security vulnerability fix:
[CVE for dependency jackson-databind](eclipse-ee4j/jersey#5225)

4.Full Release Notes:
https://github.com/eclipse-ee4j/jersey/releases/tag/2.40
https://github.com/eclipse-ee4j/jersey/releases/tag/2.39
https://github.com/eclipse-ee4j/jersey/releases/tag/2.38
https://github.com/eclipse-ee4j/jersey/releases/tag/2.37

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA.

Closes apache#41874 from panbingkun/SPARK-44316.

Authored-by: panbingkun <pbk1982@gmail.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0