optimize: improve readability of the DesignerJsonTransformer class #7316
Conversation
|
Error: /home/runner/work/incubator-seata/incubator-seata/saga/seata-saga-statelang/src/main/java/org/apache/seata/saga/statelang/parser/utils/DesignerJsonTransformer.java:152: 'lambda arguments' has incorrect indentation level 20, expected level should be 16. [Indentation] |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7316 +/- ##
============================================
+ Coverage 58.41% 58.44% +0.02%
Complexity 535 535
============================================
Files 1272 1272
Lines 45853 45859 +6
Branches 5520 5518 -2
============================================
+ Hits 26785 26801 +16
+ Misses 16546 16541 -5
+ Partials 2522 2517 -5
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
|
||
| transformNode(machineJsonObject, nodeMap, nodeObj); | ||
| } | ||
| for (Object node : nodes) { |
There was a problem hiding this comment.
From the syntax is correct. However, in terms of business semantics, nodes are the basis of edges. Without nodes, there must be no edges.
There was a problem hiding this comment.
I believe that nodes and edges only make sense in JSON when both are present; having only one of them is meaningless.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews