8000 Update build-docker.sh - Removing debug flag by windhamwong · Pull Request #3799 · apache/incubator-heron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Update build-docker.sh - Removing debug flag #3799

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Conversation

windhamwong
Copy link
Contributor

Removing the debug message on build-docker.sh

Removing the debug message on build-docker.sh
@windhamwong windhamwong changed the title Update build-docker.sh Update build-docker.sh - Removing debug flag Mar 25, 2022
@@ -58,7 +58,6 @@ run_build() {
break
fi
done
echo $DOCKER_SQUASH
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for removing this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it is a debug flag here only, without meaning.
Most of the time (at least i never see other than this) is showing False and this is it.

@joshfischer1108 joshfischer1108 merged commit 3bca1c0 into master Mar 25, 2022
@joshfischer1108 joshfischer1108 deleted the build-docker-pr branch March 25, 2022 16:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0