Updated to support Kubernetes 1.16 #3426
Conversation
| } | ||
| } catch (IOException | ApiException e) { | ||
| final V1StatefulSet response = | ||
| client.createNamespacedStatefulSet(getNamespace(), statefulSet, null, |
There was a problem hiding this comment.
Should we check if the response is successful here?
There was a problem hiding this comment.
I believe the ApiException will have the status code because the ApiClient class checks the status code and throws the exception if there is an error. Is there any better logging you would suggest in the catch block when we deal with the ApiException?
Here is a link to the ApiClient.handleResponse() logic.
There was a problem hiding this comment.
Nothing off the top of my head that would make it any better. It looks like the client handles printing out enough information. We can always come back and add more logging if we run into issues or someone requests it.
|
I just realized there is now a 7.0.0 release of the Kubernetes Java client. I'm upgrading to use that version. Will also update okhttp dependency from 2.7.5 to 3.4.14. This is the version referenced in the k8s client pom.xml. |
116d184 to
790c276
Compare
ae5331c to
c09c6a4
Compare
c09c6a4 to
0f105be
Compare
|
@nicknezis I think you were doing some additional work on this PR. Is this ready to review again or should we wait? |
|
I think it's ready to review. I'm working on making the K8s client the internal cluster config, but that can be submitted as a separate pull request. |
* Updating to fix deprecated Kubernetes APIs * Removing the old controller logic * Formatting cleanup * Trying to use latest k8s java client * Updated to use the latest K8s client * Updated tools k8s limits * Fix for missing statefulset selector in Helm chart * Updated to K8s client 7.0.0 * Code cleanup * Updated gson and added gson-fire dependencies * Updates to better handle k8s resource delete
* Updating to fix deprecated Kubernetes APIs * Removing the old controller logic * Formatting cleanup * Trying to use latest k8s java client * Updated to use the latest K8s client * Updated tools k8s limits * Fix for missing statefulset selector in Helm chart * Updated to K8s client 7.0.0 * Code cleanup * Updated gson and added gson-fire dependencies * Updates to better handle k8s resource delete
Updating to the latest Kubernetes Java client and API.