8000 IGNITE-23856 channel connection retry in ASYNC case by FewJuho · Pull Request #11954 · apache/ignite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

IGNITE-23856 channel connection retry in ASYNC case #11954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 47 commits into from
Jun 11, 2025
Merged

IGNITE-23856 channel connection retry in ASYNC case #11954

merged 47 commits into from
Jun 11, 2025

Conversation

FewJuho
Copy link
Contributor
@FewJuho FewJuho commented Mar 20, 2025

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

@FewJuho FewJuho changed the title IGNITE-23856 channel connection retry in async case IGNITE-23856 channel connection retry in ASYNC case Mar 20, 2025
@FewJuho FewJuho force-pushed the ignite-23856_async branch 2 times, most recently from e9709e5 to 36356e7 Compare April 2, 2025 02:25
@FewJuho FewJuho force-pushed the ignite-23856_async branch 2 times, most recently from 9630597 to b3bfa4c Compare April 3, 2025 15:44
@FewJuho FewJuho force-pushed the ignite-23856_async branch from b3bfa4c to 22a9b8e Compare April 3, 2025 15:49
@FewJuho FewJuho force-pushed the ignite-23856_async branch from c4c52db to ac99c76 Compare April 8, 2025 13:26
@FewJuho FewJuho force-pushed the ignite-23856_async branch from cf1b392 to 5a7fb3b Compare April 23, 2025 17:56
@FewJuho FewJuho force-pushed the ignite-23856_async branch from 5a7fb3b to 787ce64 Compare April 23, 2025 18:00
@FewJuho FewJuho force-pushed the ignite-23856_async branch from d393e2a to 9cbb15e Compare April 28, 2025 15:26
@FewJuho FewJuho force-pushed the ignite-23856_async branch from f684601 to 4db49ad Compare May 12, 2025 10:00
timoninmaxim
timoninmaxim requested changes May 12, 2025
View reviewed changes
modules/core/src/main/java/org/apache/ignite/internal/client/thin/ReliableChannel.java Outdated
.handle((res, err) -> {
ch.serviceAsync(op, payloadWriter, payloadReader)
.whenComplete((res, err) -> {
if (fut.isDone())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which case the future is done here?

modules/core/src/main/java/org/apache/ignite/internal/client/thin/ReliableChannel.java Outdated

return null;
applyOnClientChannelAsync(fut, newCh, op, payloadWriter, payloadReader, failures);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you will fall in a recursion here.

timoninmaxim
timoninmaxim reviewed May 26, 2025
View reviewed changes
modules/core/src/main/java/org/apache/ignite/internal/client/thin/ReliableChannel.java Outdated
Function<PayloadInputChannel, T> payloadReader,
List<ClientConnectionException> failures
) {
ClientConnectionException err = failures.get(failures.size() - 1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of retry in applyOnClientChannelAsync, the failures collection isn't populated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not fixed

@FewJuho FewJuho force-pushed the ignite-23856_async branch from f22b5c1 to 48a73ed Compare May 29, 2025 17:44
@FewJuho FewJuho force-pushed the ignite-23856_async branch from a4f7a30 to 57ebb5f Compare June 9, 2025 17:09
@FewJuho FewJuho force-pushed the ignite-23856_async branch from 57ebb5f to 1362af8 Compare June 9, 2025 17:10
@timoninmaxim timoninmaxim merged commit d316195 into apache:IGNITE-23856__thin_cln_channels_duplication Jun 11, 2025
7 checks passed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timoninmaxim timoninmaxim timoninmaxim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FewJuho @timoninmaxim
0