[feature] support auto nacos service discovery #3324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calvin979
requested changes
May 10, 2025
yuluo-yx
reviewed
May 11, 2025
...lector-basic/src/main/java/org/apache/hertzbeat/collector/collect/sd/NacosSdCollectImpl.java
Outdated
Show resolved
Hide resolved
yuluo-yx
reviewed
May 11, 2025
...at-common/src/main/java/org/apache/hertzbeat/common/entity/job/protocol/NacosSdProtocol.java
Outdated
Show resolved
Hide resolved
yuluo-yx
reviewed
May 11, 2025
9 tasks
|
hi please fix these conflict |
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Rancho-7
approved these changes
May 16, 2025
There was a problem hiding this comment.
Hi @xiaomizhou2 , thanks for implementing this. Could you please add a unit test for this case as well?
of course |
Rancho-7
reviewed
May 16, 2025
...tor-basic/src/test/java/org/apache/hertzbeat/collector/collect/sd/HttpSdCollectImplTest.java
Outdated
Show resolved
Hide resolved
|
LGTM overall, do you have any other thoughts or suggestions Tom? @tomsun28 |
Rancho-7
approved these changes
May 17, 2025
No yet, LGTM. |
Calvin979
requested changes
May 18, 2025
...lector-basic/src/main/java/org/apache/hertzbeat/collector/collect/sd/NacosSdCollectImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: zhangyaxi <yaxi.zhang950408@outlook.com>
Calvin979
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
#3321
The implementation of authentication has not been added yet, and can be put into the follow-up for optimization.
Checklist
Add or update API