8000 HDFS-15791. Possible Resource Leak in FSImageFormatProtobuf by Nargeshdb · Pull Request #2652 · apache/hadoop · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

HDFS-15791. Possible Resource Leak in FSImageFormatProtobuf #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2021
Merged

HDFS-15791. Possible Resource Leak in FSImageFormatProtobuf #2652

merged 1 commit into from
Feb 1, 2021

Conversation

Nargeshdb
Copy link
Contributor

This PR fixes the issue mentioned here.

@Nargeshdb Nargeshdb changed the title HDFS-15791. fix a possible resource leak HDFS-15791. Possible Resource Leak in FSImageFormatProtobuf Jan 26, 2021
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 25s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 39m 55s trunk passed
+1 💚 compile 1m 43s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 compile 1m 31s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 checkstyle 1m 3s trunk passed
+1 💚 mvnsite 1m 40s trunk passed
+1 💚 shadedclient 21m 48s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 4s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javadoc 1m 36s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+0 🆗 spotbugs 3m 26s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 3m 23s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 1m 13s the patch passed
+1 💚 compile 1m 16s the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javac 1m 16s the patch passed
+1 💚 compile 1m 9s the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 javac 1m 9s the patch passed
-0 ⚠️ checkstyle 0m 41s /diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs-project/hadoop-hdfs: The patch generated 7 new + 22 unchanged - 0 fixed = 29 total (was 22)
+1 💚 mvnsite 1m 13s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 16m 37s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 48s the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javadoc 1m 21s the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 findbugs 3m 20s the patch passed
_ Other Tests _
-1 ❌ unit 221m 45s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 46s The patch does not generate ASF License warnings.
326m 44s
Reason Tests
Failed junit tests hadoop.hdfs.server.namenode.TestDecommissioningStatus
hadoop.hdfs.TestRollingUpgrade
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2652/1/artifact/out/Dockerfile
GITHUB PR #2652
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 81f60f13913a 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 06a5d34
Default Java Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2652/1/testReport/
Max. process+thread count 2604 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2652/1/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

jojochuang
jojochuang approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor
@jojochuang jojochuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM merging this one.

@jojochuang jojochuang merged commit 115623a into apache:trunk Feb 1, 2021
asfgit pushed a commit that referenced this pull request Mar 24, 2021
@Nargeshdb @jojochuang
HDFS-15791. Possible Resource Leak in FSImageFormatProtobuf. (#2652)
f07bde9 
(cherry picked from commit 115623a)
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
@Nargeshdb
HDFS-15791. Possible Resource Leak in FSImageFormatProtobuf. (apache#…
1b4a44d 
…2652)

(cherry picked from commit 115623a)
Change-Id: I0d3b7a963d16c3f80dc0e1c8c74e0a88bc558cfd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jojochuang jojochuang jojochuang approved these changes

@goiri goiri goiri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nargeshdb @hadoop-yetus @jojochuang @goiri
0