8000 HADOOP-19343. Add support for hflush() by arunkumarchacko · Pull Request #7761 · apache/hadoop · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

HADOOP-19343. Add support for hflush() #7761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

HADOOP-19343. Add support for hflush() #7761

wants to merge 5 commits into from

Conversation

arunkumarchacko
Copy link

Fix some of the contract tests

Description of PR

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

arunkumarchacko and others added 5 commits June 18, 2025 04:24
@arunkumarchacko @cnauroth
HADOOP-19343: GCS / Add implementation for create() API
4935405 
Closes apache#7656

Signed-off-by: Chris Nauroth <cnauroth@apache.org>
@arunkumarchacko @cnauroth
HADOOP-19343: Add support for mkdir() and getFileStatus()
d90291a 
Closes apache#7721

Signed-off-by: Chris Nauroth <cnauroth@apache.org>
@arunkumarchacko @cnauroth
HADOOP-19343: Add instruction for running tests
3d29867 
Closes apache#7734

Signed-off-by: Chris Nauroth <cnauroth@apache.org>
@arunkumarchacko @cnauroth
HADOOP-19343: Add support for open() and rename()
1b12f77 
Closes apache#7742

Signed-off-by: Chris Nauroth <cnauroth@apache.org>
@arunkumarchacko
HADOOP-19343. Add support for hflush()
dbaea68 
Fix some of the contract tests
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 4 new or modified test files.
_ HADOOP-19343 Compile Tests _
+1 💚 mvninstall 46m 27s HADOOP-19343 passed
+1 💚 compile 0m 28s HADOOP-19343 passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 compile 0m 27s HADOOP-19343 passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 0m 28s HADOOP-19343 passed
+1 💚 mvnsite 0m 32s HADOOP-19343 passed
+1 💚 javadoc 0m 34s HADOOP-19343 passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 28s HADOOP-19343 passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 0m 48s HADOOP-19343 passed
+1 💚 shadedclient 35m 13s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 10m 39s the patch passed
+1 💚 compile 0m 19s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javac 0m 19s the patch passed
+1 💚 compile 0m 18s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 javac 0m 18s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 16s the patch passed
+1 💚 mvnsite 0m 21s the patch passed
+1 💚 javadoc 0m 20s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 18s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 0m 46s the patch passed
+1 💚 shadedclient 35m 30s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 27s hadoop-gcp in the patch passed.
+1 💚 asflicense 0m 39s The patch does not generate ASF License warnings.
138m 5s
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7761/1/artifact/out/Dockerfile
GITHUB PR #7761
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname Linux 2902c3ab19d5 5.15.0-136-generic #147-Ubuntu SMP Sat Mar 15 15:53:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision HADOOP-19343 / dbaea68
Default Java Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7761/1/testReport/
Max. process+thread count 705 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-gcp U: hadoop-tools/hadoop-gcp
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7761/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

cnauroth
cnauroth approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor
@cnauroth cnauroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. I'll commit this to the feature branch later today.

hadoop-tools/hadoop-gcp/src/main/java/org/apache/hadoop/fs/gs/GoogleHadoopOutputStream.java
statistics.incrementBytesWritten(len);
statistics.incrementWriteOps(1);
}

private void commitTempFile() throws IOException {
// TODO(user): return early when 0 bytes have been written in the temp files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to remove the "(user)" when I commit this. This is a Google commenting standard, but it's not typical here in the Apache Hadoop codebase.

cnauroth added a commit that referenced this pull request Jun 25, 2025
@arunkumarchacko @cnauroth
HADOOP-19343. Add support for hflush()
16eb182 
Closes #7761

Co-authored-by: Chris Nauroth <cnauroth@apache.org>
Signed-off-by: Chris Nauroth <cnauroth@apache.org>
@cnauroth
Copy link
Contributor

I committed this to the feature branch. Thanks again @arunkumarchacko !

@cnauroth cnauroth closed this Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnauroth cnauroth cnauroth approved these changes

Assignees
No one assigned
Labels
TOOLS trunk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arunkumarchacko @hadoop-yetus @cnauroth
0