HADOOP-19525: used java.time.Clock instead of org.apache.hadoop.util.Clock #7570
+954
−1,048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
0192cc1 to
3e7a4ee
Compare
|
💔 -1 overall
This message was automatically generated. |
3e7a4ee to
c40437d
Compare
pan3793
reviewed
Apr 3, 2025
| */ | ||
| @Public | ||
| @Stable | ||
| @Deprecated |
There was a problem hiding this comment.
it was added in YARN-11765 (3.5.0, an unreleased version), why not just revert the change first?
There was a problem hiding this comment.
@pan3793 You're right, it would appear as if 3.5.0 new deprecated classes!
I've removed the moved classes in the latest commit.
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
48fe431 to
f3f1798
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
@pan3793 @slfan1989 @cnauroth - this rides on the waves of @yangjiandan's work in #7352 for YARN-11765. |
pan3793
reviewed
Apr 9, 2025
| * Subclasses that want to change this behavior can either override relevant methods or | ||
| * subclass {@link java.time.Clock} directly. | ||
| */ | ||
| public abstract class AbstractClock extends Clock { |
There was a problem hiding this comment.
this is a public api but seems unnecessary
There was a problem hiding this comment.
the rest of changes lgtm
sorry, I have to retract this after a closer look.
There was a problem hiding this comment.
@pan3793 thanks for the review!
This just serves as base class for Clocks that don't need to deal with ZoneIds and mostly handle times natively via milliseconds (converting to Instants and not vice-versa).
The alternative would be to just delete it and have the two subclasses implement this common behavior.
I can also mark it with @LimitedPrivate and limit it to either -
- The only module currently using it (YARN, in ControlledClock)
- All modules currently using
java.time.Clock(after this change - YARN, tools, MapReduce)
I think I prefer the first approach (delete the class) since it doesn't save too much boilerplate anyway.
wdyt?
pan3793
reviewed
Apr 9, 2025
| import java.util.Collection; | ||
|
|
||
| import org.apache.hadoop.yarn.server.resourcemanager.scheduler.ResourceScheduler; | ||
| import org.apache.hadoop.util.Clock; |
There was a problem hiding this comment.
I just took a closer look, org.apache.hadoop.util.Clock was actually exposed to the public API, such changes bring unnecessary compatibility issues. Given Hadoop is already in a post-mature state, I would avoid such changes as much as possible.
Back to the original intention of the changes, how about leaving the org.apache.hadoop.yarn.util.Clock as-is (which means reverting YARN-11765), and introducing a new Clock implementation in the Common module based on the JDK Clock for new use cases?
There was a problem hiding this comment.
@pan3793 you're completely right, but YARN-11765 was already merged - and changed the same public API (by moving the class from import org.apache.hadoop.yarn.util to org.apache.hadoop.util).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Closes HADOOP-19525
How was this patch tested?
Ran all existing tests.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?