HADOOP-15760. Upgrade commons-collections to commons-collections4 #7006

NihalJain · 2024-08-19T07:16:32Z

Description of PR

Excluded commons-collections 3 and all instances of it along with completely banning it from the build/assembly
Upgraded to commons-collections4 and made migrated imports and code as per the new package

How was this patch tested?

Ran mvn clean install -DskipTests and ensure code build. Will see how jenkins reacts with UTs!

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

- Excluded commons-collections and completely banned it - Upgraded to commons-collections and made changes as per the new package

NihalJain · 2024-08-19T07:21:40Z

Hi @steveloughran I have upgraded to commons-collections4 and not just included it as per JIRA description. If this is fine for others, we may need to update jira description as well to keep in sync. Else I can fall back to actual ask which was "Include Apache Commons Collections4". But again commons-collections:commons-collections:3.2.2 has a possible CVE: sonatype-2024-3350, also see https://issues.apache.org/jira/browse/COLLECTIONS-701. So we may not want to keep in for new releases!

steveloughran · 2024-08-19T17:38:56Z

too big a change for 3.4.1, but I'm looking at a 3.4.2 release with dependency updates and a move to java11+ only (!)... (ideally few feature changes, just major bug fixes)

hadoop-yetus · 2024-08-20T05:23:13Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 51s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+0 🆗	shelldocs	0m 1s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 9 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 39s		Maven dependency ordering for branch
+1 💚	mvninstall	39m 7s		trunk passed
+1 💚	compile	21m 58s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	compile	20m 25s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	checkstyle	4m 57s		trunk passed
+1 💚	mvnsite	26m 29s		trunk passed
+1 💚	javadoc	10m 20s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javadoc	8m 38s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+0 🆗	spotbugs	0m 20s		branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+0 🆗	spotbugs	0m 36s		branch/hadoop-client-modules/hadoop-client-minicluster no spotbugs output file (spotbugsXml.xml)
-1 ❌	spotbugs	33m 37s	/branch-spotbugs-root-warnings.html	root in trunk has 2 extant spotbugs warnings.
+1 💚	shadedclient	71m 15s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 31s		Maven dependency ordering for patch
+1 💚	mvninstall	61m 17s		the patch passed
+1 💚	compile	18m 52s		the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javac	18m 52s		the patch passed
+1 💚	compile	17m 35s		the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	javac	17m 35s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	4m 39s		the patch passed
+1 💚	mvnsite	17m 31s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	javadoc	8m 50s		the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javadoc	7m 41s		the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+0 🆗	spotbugs	0m 18s		hadoop-project has no data from spotbugs
+0 🆗	spotbugs	0m 22s		hadoop-client-modules/hadoop-client-minicluster has no data from spotbugs
+1 💚	shadedclient	73m 43s		patch has no 8000 errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	825m 47s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	1m 34s		The patch does not generate ASF License warnings.
		1325m 10s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.federation.router.TestRouterClientRejectOverload
	hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage
	hadoop.yarn.server.timelineservice.storage.TestTimelineReaderHBaseDown
	hadoop.yarn.server.timelineservice.storage.flow.TestHBaseStorageFlowActivity
	hadoop.yarn.server.timelineservice.storage.flow.TestHBaseStorageFlowRunCompaction
	hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageApps
	hadoop.yarn.server.timelineservice.storage.TestTimelineWriterHBaseDown
	hadoop.yarn.server.timelineservice.storage.flow.TestHBaseStorageFlowRun
	hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageEntities
	hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageDomain

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7006/1/artifact/out/Dockerfile
GITHUB PR	#7006
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle shellcheck shelldocs
uname	Linux d580df2debab 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `ce5860e`
Default Java	Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7006/1/testReport/
Max. process+thread count	3116 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-hdfs-project/hadoop-hdfs-rbf hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-documentstore hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp hadoop-tools/hadoop-aws hadoop-tools/hadoop-aliyun hadoop-tools/hadoop-sls hadoop-client-modules/hadoop-client-minicluster . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7006/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-08-21T17:54:29Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	18m 25s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+0 🆗	shelldocs	0m 1s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 9 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	19m 7s		Maven dependency ordering for branch
+1 💚	mvninstall	37m 12s		trunk passed
+1 💚	compile	19m 54s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	compile	18m 2s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	checkstyle	4m 51s		trunk passed
+1 💚	mvnsite	26m 40s		trunk passed
+1 💚	javadoc	9m 15s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javadoc	7m 59s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+0 🆗	spotbugs	0m 18s		branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+0 🆗	spotbugs	0m 24s		branch/hadoop-client-modules/hadoop-client-minicluster no spotbugs output file (spotbugsXml.xml)
-1 ❌	spotbugs	32m 7s	/branch-spotbugs-root-warnings.html	root in trunk has 2 extant spotbugs warnings.
+1 💚	shadedclient	70m 34s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	1m 3s		Maven dependency ordering for patch
+1 💚	mvninstall	59m 32s		the patch passed
+1 💚	compile	19m 4s		the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javac	19m 4s		the patch passed
+1 💚	compile	17m 52s		the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	javac	17m 52s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	4m 45s		the patch passed
+1 💚	mvnsite	20m 18s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	javadoc	9m 4s		the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javadoc	8m 1s		the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+0 🆗	spotbugs	0m 20s		hadoop-project has no data from spotbugs
+0 🆗	spotbugs	0m 23s		hadoop-client-modules/hadoop-client-minicluster has no data from spotbugs
+1 💚	shadedclient	70m 50s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	819m 26s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	1m 42s		The patch does not generate ASF License warnings.
		1327m 53s

Reason	Tests
Failed junit tests	hadoop.yarn.server.timelineservice.storage.flow.TestHBaseStorageFlowRun
	hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage
	hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageDomain
	hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageApps
	hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageEntities
	hadoop.yarn.server.timelineservice.storage.TestTimelineWriterHBaseDown
	hadoop.yarn.server.timelineservice.storage.TestTimelineReaderHBaseDown
	hadoop.yarn.server.timelineservice.storage.flow.TestHBaseStorageFlowActivity
	hadoop.yarn.server.timelineservice.storage.flow.TestHBaseStorageFlowRunCompaction
	hadoop.hdfs.TestRollingUpgrade

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7006/3/artifact/out/Dockerfile
GITHUB PR	#7006
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle shellcheck shelldocs
uname	Linux a1242191a790 5.15.0-118-generic #128-Ubuntu SMP Fri Jul 5 09:28:59 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `ce5860e`
Default Java	Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7006/3/testReport/
Max. process+thread count	3479 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-hdfs-project/hadoop-hdfs-rbf hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-documentstore hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp hadoop-tools/hadoop-aws hadoop-tools/hadoop-aliyun hadoop-tools/hadoop-sls hadoop-client-modules/hadoop-client-minicluster . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7006/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2024-08-21T19:00:12Z

Failures seem to be related to #6953 and #6998

NihalJain · 2024-08-30T07:35:40Z

/build

steveloughran · 2024-08-30T10:43:48Z

afraid to force a build you need to do a git branch merge onto trunk.

hadoop-yetus · 2024-08-31T05:04:22Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	44m 36s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 2s		No case conflicting files found.
+0 🆗	codespell	0m 2s		codespell was not available.
+0 🆗	detsecrets	0m 2s		detect-secrets was not available.
+0 🆗	shellcheck	0m 2s		Shellcheck was not available.
+0 🆗	shelldocs	0m 2s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 9 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 40s		Maven dependency ordering for branch
+1 💚	mvninstall	38m 23s		trunk passed
+1 💚	compile	17m 40s		trunk passed
+1 💚	checkstyle	4m 59s		trunk passed
+1 💚	mvnsite	26m 57s		trunk passed
+1 💚	javadoc	8m 17s		trunk passed
+0 🆗	spotbugs	0m 20s		branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+0 🆗	spotbugs	0m 25s		branch/hadoop-client-modules/hadoop-client-minicluster no spotbugs output file (spotbugsXml.xml)
-1 ❌	spotbugs	32m 53s	/branch-spotbugs-root-warnings.html	root in trunk has 2 extant spotbugs warnings.
+1 💚	shadedclient	70m 16s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 32s		Maven dependency ordering for patch
+1 💚	mvninstall	61m 6s		the patch passed
+1 💚	compile	17m 41s		the patch passed
+1 💚	javac	17m 41s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	4m 55s		the patch passed
+1 💚	mvnsite	18m 32s		the patch passed
+1 💚	xmllint	0m 1s		No new issues.
+1 💚	javadoc	8m 15s		the patch passed
+0 🆗	spotbugs	0m 22s		hadoop-project has no data from spotbugs
+0 🆗	spotbugs	0m 24s		hadoop-client-modules/hadoop-client-minicluster has no data from spotbugs
+1 💚	shadedclient	75m 37s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	805m 0s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	1m 43s		The patch does not generate ASF License warnings.
		1284m 38s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.federation.router.TestRouterRpc
	hadoop.hdfs.TestRollingUpgrade
	hadoop.fs.http.server.TestHttpFSServer
	hadoop.service.launcher.TestServiceInterruptHandling
	hadoop.tools.TestHadoopArchiveLogs

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7006/4/artifact/out/Dockerfile
GITHUB PR	#7006
Optional Tests	dupname asflicense codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall mvnsite unit shadedclient xmllint spotbugs checkstyle
uname	Linux 29e53d2700dc 5.15.0-119-generic #129-Ubuntu SMP Fri Aug 2 19:25:20 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `ce5860e`
Default Java	Red Hat, Inc.-1.8.0_412-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7006/4/testReport/
Max. process+thread count	3145 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-hdfs-project/hadoop-hdfs-rbf hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-documentstore hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp hadoop-tools/hadoop-aws hadoop-tools/hadoop-aliyun hadoop-tools/hadoop-sls hadoop-client-modules/hadoop-client-minicluster . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7006/4/console
versions	git=2.9.5 maven=3.6.3 spotbugs=4.2.2 xmllint=20901
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-09-03T17:34:04Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	24m 14s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 9 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 48s		Maven dependency ordering for branch
+1 💚	mvninstall	36m 44s		trunk passed
+1 💚	compile	19m 34s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	compile	17m 50s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	checkstyle	4m 49s		trunk passed
+1 💚	mvnsite	26m 51s		trunk passed
+1 💚	javadoc	9m 15s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javadoc	7m 58s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+0 🆗	spotbugs	0m 19s		branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+0 🆗	spotbugs	0m 24s		branch/hadoop-client-modules/hadoop-client-minicluster no spotbugs output file (spotbugsXml.xml)
-1 ❌	spotbugs	32m 18s	/branch-spotbugs-root-warnings.html	root in trunk has 2 extant spotbugs warnings.
+1 💚	shadedclient	70m 37s		branch has no errors when building and testing our client artifacts.
-0 ⚠️	patch	71m 1s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+0 🆗	mvndep	1m 3s		Maven dependency ordering for patch
+1 💚	mvninstall	59m 24s		the patch passed
+1 💚	compile	18m 57s		the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javac	18m 57s		the patch passed
+1 💚	compile	17m 51s		the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	javac	17m 51s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	4m 46s		the patch passed
+1 💚	mvnsite	19m 2s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	javadoc	9m 6s		the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javadoc	7m 58s		the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+0 🆗	spotbugs	0m 20s		hadoop-project has no data from spotbugs
+0 🆗	spotbugs	0m 23s		hadoop-client-modules/hadoop-client-minicluster has no data from spotbugs
+1 💚	shadedclient	70m 27s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	809m 21s		root in the patch passed.
+1 💚	asflicense	1m 37s		The patch does not generate ASF License warnings.
		1316m 52s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7006/7/artifact/out/Dockerfile
GITHUB PR	#7006
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle shellcheck shelldocs
uname	Linux e72ed6e8ad2a 5.15.0-119-generic #129-Ubuntu SMP Fri Aug 2 19:25:20 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `179c13e`
Default Java	Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7006/7/testReport/
Max. process+thread count	3137 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-hdfs-project/hadoop-hdfs-rbf hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-documentstore hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp hadoop-tools/hadoop-aws hadoop-tools/hadoop-aliyun hadoop-tools/hadoop-sls hadoop-client-modules/hadoop-client-minicluster . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7006/7/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2024-09-03T18:43:50Z

Hi @steveloughran the UT failures are gone now. Please let me know if any changes needed in this PR.

NihalJain · 2024-09-16T20:29:36Z

Gentle ping @steveloughran

steveloughran

+1. lets get into trunk and see if anyone complains.

Can you do a PR for branch-3.4 -we can merge it if yetus is happy

NihalJain · 2024-09-24T17:08:09Z

+1. lets get into trunk and see if anyone complains.

Thank you @steveloughran for merging into trunk.

Can you do a PR for branch-3.4 -we can merge it if yetus is happy

Sure let me put up a PR for same.

) (#7097) This moves Hadoop to Apache commons-collections4. Apache commons-collections has been removed and is completely banned from the source code. Contributed by Nihal Jain

HADOOP-15760 Upgrade to Apache Commons Collections4

ce5860e

- Excluded commons-collections and completely banned it - Upgraded to commons-collections and made changes as per the new package

github-actions bot added YARN MapReduce HDFS build trunk Common RBF TOOLS AWS labels Aug 19, 2024

Merge branch 'trunk' into HADOOP-15760

179c13e

steveloughran approved these changes Sep 24, 2024

View reviewed changes

steveloughran changed the title ~~HADOOP-15760 Upgrade commons-collections to commons-collections4~~ HADOOP-15760. Upgrade commons-collections to commons-collections4 Sep 24, 2024

steveloughran merged commit e602c60 into apache:trunk Sep 24, 2024
1 of 4 checks passed

NihalJain mentioned this pull request Oct 3, 2024

HADOOP-15760. Upgrade commons-collections to commons-collections4 #7097

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HADOOP-15760. Upgrade commons-collections to commons-collections4 #7006

HADOOP-15760. Upgrade commons-collections to commons-collections4 #7006

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HADOOP-15760. Upgrade commons-collections to commons-collections4 #7006

HADOOP-15760. Upgrade commons-collections to commons-collections4 #7006

Uh oh!

Conversation

Uh oh!

Description of PR

How was this patch tested?

For code changes:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!