HDDS-1219. TestContainerActionsHandler.testCloseContainerAction has an intermittent failure #555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n intermittent failure. Contributed by Elek, Marton.
|
🎊 +1 overall
This message was automatically generated. |
|
LGTM. |
|
+1 |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
Refactored metrics for table API - Added TableMetricsUtil that encapsulates required parameters, maintains naming consistency and simplifies metrics creation API for tables. - Added metrics to local table - Maintained consistency between local, remote and caching table Author: Wei Song <wsong@wsong-mn2.linkedin.biz> Reviewers: Peng Du<pdu@linkedin.com> Closes apache#555 from weisong44/table-metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's failed multiple times during the CI builds:
{code}
Error Message
Wanted but not invoked:
closeContainerEventHandler.onMessage(
#1,
org.apache.hadoop.hdds.server.events.EventQueue@3d3fcdb0
);
-> at org.apache.hadoop.hdds.scm.container.TestContainerActionsHandler.testCloseContainerAction(TestContainerActionsHandler.java:64)
Actually, there were zero interactions with this mock.
{code}
The fix is easy: we should call queue.processAll(1000L) to wait for the processing of all the events.
See: https://issues.apache.org/jira/browse/HDDS-1219