HDDS-1216. Change name of ozoneManager service in docker compose file… #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to om. Contributed by Ajay Kumar.
hadoop-yetus
reviewed
Mar 4, 2019
| Secure S3 test Failure | ||
| Run Keyword Install aws cli | ||
| ${rc} ${result} = Run And Return Rc And Output aws s3api --endpoint-url ${ENDPOINT_URL} create-bucket --bucket bucket-test123 | ||
| Should Be True ${rc} > 0 |
hadoop-yetus
reviewed
Mar 4, 2019
| Execute kinit -k testuser/${hostname}@EXAMPLE.COM -t /etc/security/keytabs/testuser.keytab | ||
| ${result} = Execute ozone sh s3 getsecret | ||
| ${accessKey} = Get Regexp Matches ${result} (?<=awsAccessKey=).* | ||
| ${secret} = Get Regexp Matches ${result} (?<=awsSecret=).* |
There was a problem hiding this comment.
Can we remove this change from here? As this Jira purpose is not for this.
There was a problem hiding this comment.
+1 to move it to a separate Jira. Let's keep only ozoneManager -> om refactoring changes in this patch.
There was a problem hiding this comment.
removed s3 related changes, HDDS-1043 will have them.
There was a problem hiding this comment.
Still we have a few of them (commonawslib, docker-config)
There was a problem hiding this comment.
@elek thanks for catching that, removed from both files (commonawslib, docker-config).
hadoop-yetus
reviewed
Mar 4, 2019
|
💔 -1 overall
This message was automatically generated. |
| Execute kinit -k testuser/${hostname}@EXAMPLE.COM -t /etc/security/keytabs/testuser.keytab | ||
| ${result} = Execute ozone sh s3 getsecret | ||
| ${accessKey} = Get Regexp Matches ${result} (?<=awsAccessKey=).* | ||
| ${secret} = Get Regexp Matches ${result} (?<=awsSecret=).* |
There was a problem hiding this comment.
Can we remove this change from here? As this Jira purpose is not for this.
hadoop-ozone/dist/src/main/smoketest/security/ozone-secure.robot
Outdated
Show resolved
Hide resolved
| image: apache/hadoop-runner | ||
| privileged: true #required by the profiler | ||
| volumes: | ||
| - ../..:/opt/hadoop | ||
| ports: | ||
| - 9874:9874 | ||
| environment: | ||
| ENSURE_OM_INITIALIZED: /data/metadata/ozoneManager/current/VERSION | ||
| ENSURE_OM_INITIALIZED: /data/metadata/om/current/VERSION |
There was a problem hiding this comment.
Here we have changed to om, will be this be same as service name when path is created?
There was a problem hiding this comment.
changed this for consistency purpose. IMO path can be independent of service name.
hadoop-yetus
reviewed
Mar 5, 2019
| @@ -78,7 +78,7 @@ execute_tests(){ | |||
| TITLE="Ozone $TEST tests with $COMPOSE_DIR cluster" | |||
| set +e | |||
| OUTPUT_NAME="$COMPOSE_DIR-${TEST//\//_}" | |||
| docker-compose -f "$COMPOSE_FILE" exec -T ozoneManager python -m robot --log NONE --report NONE "${OZONE_ROBOT_OPTS[@]}" --output "smoketest/$RESULT_DIR/robot-$OUTPUT_NAME.xml" --logtitle "$TITLE" --reporttitle "$TITLE" "smoketest/$TEST" | |||
| docker-compose -f "$COMPOSE_FILE" exec -T om python -m robot --log NONE --report NONE "${OZONE_ROBOT_OPTS[@]}" --output "smoketest/$RESULT_DIR/robot-$OUTPUT_NAME.xml" --logtitle "$TITLE" --reporttitle "$TITLE" "smoketest/$TEST" | |||
There was a problem hiding this comment.
not sure what is the problem here, change involves just rename.
There was a problem hiding this comment.
IMHO, you modified a line which already contained a tab.
hadoop-yetus
reviewed
Mar 5, 2019
This comment has been minimized.
This comment has been minimized.
|
💔 -1 overall
This message was automatically generated. |
hadoop-yetus
reviewed
Mar 6, 2019
|
💔 -1 overall
This message was automatically generated. |
elek
approved these changes
Mar 6, 2019
|
Merged. Thanks you very much @ajayydv the contribution. I am very happy that we started to use the shorter names. |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
We require visibility into how effectively host-affinity performs. The goal is to help easily answer the following questions. - How effectively is YARN matching my preferred-host requests - When does Samza fallback to abandoning locality and issuing any-host requests? design doc: https://docs.google.com/document/d/1oeNKDnG4JIGT2846us-jpnGW_RUjMjPIKDeEUlE_-jg/edit# Author: Jagadish <jvenkatraman@linkedin.com> Reviewers: Prateek M<pmaheshw@linkedin.com> Closes apache#553 from vjagadish1989/hostaffinity-metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s to om. Contributed by Ajay Kumar.