8000 HDDS-1136 : Add metric counters to capture the RocksDB checkpointing statistics. by avijayanhwx · Pull Request #536 · apache/hadoop · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

HDDS-1136 : Add metric counters to capture the RocksDB checkpointing statistics. #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

HDDS-1136 : Add metric counters to capture the RocksDB checkpointing statistics. #536

wants to merge 3 commits into from

Conversation

avijayanhwx
Copy link
Contributor
@avijayanhwx avijayanhwx commented Feb 28, 2019 •
edited
Loading

Added metric gauges for tracking DB checkpointing statistics. The OMMetrics class will hold these guages at any instant. These can be pulled from OM by Recon.

Testing done
Integration test for Servlet method that gets the OM DB checkpoint added.
Manually verified the patch on single node Ozone cluster.

@avijayanhwx
Copy link
Contributor Author

cc @anuengineer @bharatviswa504 @arp7

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 23 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 68 Maven dependency ordering for branch
+1 mvninstall 1104 trunk passed
+1 compile 945 trunk passed
+1 checkstyle 271 trunk passed
+1 mvnsite 154 trunk passed
+1 shadedclient 1198 branch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1 findbugs 127 trunk passed
+1 javadoc 97 trunk passed
_ Patch Compile Tests _
0 mvndep 20 Maven dependency ordering for patch
-1 mvninstall 23 integration-test in the patch failed.
+1 compile 920 the patch passed
+1 javac 920 the patch passed
+1 checkstyle 207 the patch passed
-1 mvnsite 33 integration-test in the patch failed.
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 716 patch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1 findbugs 135 the patch passed
+1 javadoc 97 the patch passed
_ Other Tests _
-1 unit 83 common in the patch failed.
-1 unit 35 integration-test in the patch failed.
+1 unit 45 ozone-manager in the patch passed.
+1 asflicense 40 The patch does not generate ASF License warnings.
6326
Reason Tests
Failed junit tests hadoop.hdds.security.x509.certificate.client.TestDefaultCertificateClient
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-536/1/artifact/out/Dockerfile
GITHUB PR #536
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 773ed8ce5243 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 0d61fac
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-536/1/artifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-536/1/artifact/out/patch-mvnsite-hadoop-ozone_integration-test.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-536/1/artifact/out/patch-unit-hadoop-hdds_common.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-536/1/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-536/1/testReport/
Max. process+thread count 305 (vs. ulimit of 5500)
modules C: hadoop-hdds/common hadoop-ozone/integration-test hadoop-ozone/ozone-manager U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-536/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 patch 6 #536 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.
Subsystem Report/Notes
GITHUB PR #536
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-536/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 patch 7 #536 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.
Subsystem Report/Notes
GITHUB PR #536
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-536/3/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@avijayanhwx
Copy link
Contributor Author

I am not sure why jenkins is not able to apply my patch on trunk. I pulled from apache hadoop trunk and merged to my branch. I also verified https://github.com/apache/hadoop/pull/536.patch applies cleanly on apache hadoop trunk. @elek Is it possible jenkins is trying to apply individual commits rather than the squashed patch?

@avijayanhwx
Copy link
Contributor Author

Closing this and opening a new one with a single commit.

@avijayanhwx avijayanhwx closed this Mar 1, 2019
@avijayanhwx avijayanhwx deleted the HDDS-1136-trunk branch March 1, 2019 03:24
@elek
Copy link
Member
elek commented Mar 1, 2019

I am not sure why jenkins is not able to apply my patch on trunk. I pulled from apache hadoop trunk and merged to my branch. I also verified https://github.com/apache/hadoop/pull/536.patch applies cleanly on apache hadoop trunk. @elek Is it possible jenkins is trying to apply individual commits rather than the squashed patch?

Don't now. Could be a yetus bug. You can ask it onthe yetus dev list / jira. Or ask @aw-was-here

BTW, in the PR-s you can do force push. Github handles it very well, you don't need a new PR.

shanthoosh added a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
@shanthoosh @jagadish-v0
SAMZA-1731: Daemonize threads spawned from SamzaEventHubClientManager.
5534fba 
**Problem:**
Existing SamzaEventHubClientManager implementation spawns non-daemon threads when instantiating EventHubClient. These non-daemon threads stalls shutdown of samza processes even when the main thread has exited.

**Fix:**
Daemonize threads that are spawned from SamzaEventHubClientManager.

Author: Shanthoosh Venkataraman <santhoshvenkat1988@gmail.com>

Reviewers: Jagadish <jagadish@apache.org>

Closes apache#536 from shanthoosh/SAMZA-1731
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@avijayanhwx avijayanhwx

Labels
ozone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avijayanhwx @hadoop-yetus @elek @bharatviswa504
0