HDDS-1093. Configuration tab in OM/SCM ui is not displaying the correct values #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bharatviswa504 @avijayanhwx @arp7 Please review when you find time |
swagle
reviewed
Feb 28, 2019
hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/conf/TestOzoneConfiguration.java
Outdated
Show resolved
Hide resolved
swagle
reviewed
Feb 28, 2019
hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/conf/TestOzoneConfiguration.java
Outdated
Show resolved
Hide resolved
swagle
reviewed
Feb 28, 2019
hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/conf/TestOzoneConfiguration.java
Outdated
Show resolved
Hide resolved
|
--
Sent from my Android phone with GMX Mail. Please excuse my brevity.On 2019-02-27, 9:55 p.m. Siddharth <notifications@github.com> wrote:
@swagle commented on this pull request.
In hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/conf/TestOzoneConfiguration.java:
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+
+import java.io.BufferedWriter;
+import java.io.File;
+import java.io.FileWriter;
+import java.io.IOException;
+
+public class TestOzoneConfiguration {
+
+ private Configuration conf;
+ final static String CONFIG = new File("./test-config-TestConfiguration.xml").getAbsolutePath();
+ final static String CONFIG_CORE = new File("./core-site.xml").getAbsolutePath();
+
+ private BufferedWriter out;
In general not too excited about sharing streams as a coding best practice, others reviewers can chime in but better to localize this vs deal with side effect code in tearDown.
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/apache/hadoop","title":"apache/hadoop","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/apache/hadoop"}},"updates":{"snippets":[{"icon":"PERSON","message":"@swagle commented on #527"}],"action":{"name":"View Pull Request","url":"#527 (review)"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "#527 (review)",
"url": "#527 (review)",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
|
avijayanhwx
reviewed
Feb 28, 2019
|
💔 -1 overall
This message was automatically generated. |
elek
reviewed
Feb 28, 2019
| @@ -161,4 +163,31 @@ public static void activate() { | |||
| Configuration.addDefaultResource("ozone-default.xml"); | |||
| Configuration.addDefaultResource("ozone-site.xml"); | |||
| } | |||
|
|
|||
| /** | |||
| * The super class method getAllPropertiesByTag | |||
There was a problem hiding this comment.
Do we need an other (HADOOP) jira to fix it on the hadoop 3.3 line, too?
|
I am just wondering if it's the same issue as https://issues.apache.org/jira/browse/HDDS-611 |
Thanks @elek ! Marked it a duplicate. |
|
💔 -1 overall
This message was automatically generated. |
swagle
approved these changes
Mar 1, 2019
|
💔 -1 overall
This message was automatically generated. |
hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/conf/TestOzoneConfiguration.java
Outdated
Show resolved
Hide resolved
hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/conf/TestOzoneConfiguration.java
Outdated
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
@vivekratnavel |
|
💔 -1 overall
This message was automatically generated. |
|
Thank You @vivekratnavel for the fix. |
|
💔 -1 overall
This message was automatically generated. |
shanthoosh
added a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
In samza-sql module, currently few test classes(`TestSamzaSqlRelMessageSerde` and `TestSamzaSqlRelRecordSerde`) are dependent upon `javafx.util.Pair` class(coming from `javafx` module). `javafx.util.Pair` is not supported by default in all JDK builds(example; open-jdk java-8 doesn't support `javafx` module) and it belongs to `javafx` package which is primarily used for developing GUI applications. This dependency is removed and replaced with `Pair` class from `apache-commons`. Author: Shanthoosh Venkataraman <santhoshvenkat1988@gmail.com> Reviewers: Jagadish V <vjagadish@gmail.com> Closes apache#527 from shanthoosh/SAMZA-1720
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration tab in OM/SCM ui is not displaying the correct/configured values, rather it is displaying the default values.