HADOOP-18383. Codecs with @DoNotPool annotation are not closed causing memory leak #4585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @sunchao |
|
Thanks @kevins-29 , the fix looks good to me. However, is this addressing the issue mentioned in HADOOP-12007? my understanding is that the issue there is related to |
goiri
reviewed
Jul 19, 2022
...-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodecPool.java
Outdated
Show resolved
Hide resolved
...-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodecPool.java
Outdated
gzipCodec.createOutputStream(new ByteArrayOutputStream(), compressor)) {
outputStream.write(1);
fail("Compressor from Codec with @DoNotPool should not be useable after returning to CodecPool");
} catch (NullPointerException exception) {
There was a problem hiding this comment.
Unfortunately I couldn't find another way to test that the underlying Compressor/Decompress has been closed. There is finished but that is set by reset() and has different semantics.
There was a problem hiding this comment.
Could we add a check in the place where we would encounter the null and trigger a more friendly exception from there?
Something like an already closed exception?
| gzipCodec.createOutputStream(new ByteArrayOutputStream(), compressor)) { | ||
| outputStream.write(1); | ||
| fail("Compressor from Codec with @DoNotPool should not be useable after returning to CodecPool"); | ||
| } catch (NullPointerException exception) { |
There was a problem hiding this comment.
Unfortunately I couldn't find another way to test that the underlying Compressor/Decompress has been closed. There is finished but that is set by reset() and has different semantics.
There was a problem hiding this comment.
Could we add a check in the place where we would encounter the null and trigger a more friendly exception from there?
Something like an already closed exception?
...-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodecPool.java
Outdated
Show resolved
Hide resolved
goiri
reviewed
Jul 19, 2022
...-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodecPool.java
Outdated
Show resolved
Hide resolved
@sunchao Should I create a new Jira ticket for this? |
@kevins-29 , yes please create a new JIRA for this issue, and change the PR title afterwards. Thanks. |
|
🎊 +1 overall
This message was automatically generated. |
sunchao
reviewed
Aug 4, 2022
...roject/hadoop-common/src/main/java/org/apache/hadoop/io/compress/AlreadyClosedException.java
Outdated
Show resolved
Hide resolved
...ct/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/BuiltInGzipCompressor.java
Outdated
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
viirya
approved these changes
Aug 12, 2022
|
lgtm, but why there are many failures in CI? |
|
There's one unit test failure: which is unrelated. |
|
Merged to trunk, thanks @kevins-29 ! |
|
@kevins-29 could you open a PR targeting |
|
@sunchao will do. |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Explicitly call
end()when returningCompressororDecompressorimplementations withDoNotPoolannotation to theCodecPool.How was this patch tested?
I created the following project to demo the leak. You can run the demo with
and then monitor the memory usage using
Results - Before Patch
Results - After Patch