8000 MAPREDUCE-7121. add Abortable so that we can abort output by bschell · Pull Request #402 · apache/hadoop · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MAPREDUCE-7121. add Abortable so that we can abort output #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

MAPREDUCE-7121. add Abortable so that we can abort output #402

wants to merge 1 commit into from
+143 −12

Conversation

bschell
Copy link
@bschell bschell commented Jul 10, 2018

This patch adds abortable to mapreduce outputs

In the case of using a remote filesystem with mapreduce, upon task attempt failure we ensure the file output stream gets aborted before being closed which prevents partial results from being uploaded.

add Abortable so that we can abort output
1d0c393 
This adds abortable so we can abort output in the case of a task attempt that is successful even though it failed to generate output files
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 37 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 25 Maven dependency ordering for branch
+1 mvninstall 1043 trunk passed
+1 compile 1050 trunk passed
+1 checkstyle 150 trunk passed
+1 mvnsite 122 trunk passed
+1 shadedclient 986 branch has no errors when building and testing our client artifacts.
+1 javadoc 87 trunk passed
0 spotbugs 80 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 191 trunk passed
_ Patch Compile Tests _
0 mvndep 22 Maven dependency ordering for patch
+1 mvninstall 74 the patch passed
+1 compile 1023 the patch passed
-1 javac 1023 root generated 1 new + 1476 unchanged - 0 fixed = 1477 total (was 1476)
-0 checkstyle 147 root: The patch generated 10 new + 854 unchanged - 2 fixed = 864 total (was 856)
-1 mvnsite 38 hadoop-mapreduce-client-core in the patch failed.
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 635 patch has no errors when building and testing our client artifacts.
+1 javadoc 80 the patch passed
-1 findbugs 122 hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-1 findbugs 34 hadoop-mapreduce-client-core in the patch failed.
_ Other Tests _
-1 unit 534 hadoop-common in the patch failed.
-1 unit 41 hadoop-mapreduce-client-core in the patch failed.
-1 asflicense 38 The patch generated 2 ASF License warnings.
6522
Reason Tests
FindBugs module:hadoop-common-project/hadoop-common
instanceof will always return true for all non-null values in org.apache.hadoop.io.SequenceFile$Writer.abort(), since all org.apache.hadoop.fs.FSDataOutputStream are instances of org.apache.hadoop.fs.common.Abortable At SequenceFile.java:for all non-null values in org.apache.hadoop.io.SequenceFile$Writer.abort(), since all org.apache.hadoop.fs.FSDataOutputStream are instances of org.apache.hadoop.fs.common.Abortable At SequenceFile.java:[line 881]
Failed junit tests hadoop.ipc.TestIPC
Subsystem Report/Notes
Docker Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-402/1/artifact/out/Dockerfile
GITHUB PR #402
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux b0653e3166ad 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 7f1b76c
Default Java 1.8.0_212
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-402/1/artifact/out/diff-compile-javac-root.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-402/1/artifact/out/diff-checkstyle-root.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-402/1/artifact/out/patch-mvnsite-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-402/1/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-402/1/artifact/out/patch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-402/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-402/1/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-402/1/testReport/
asflicense https://builds.apache.org/job/hadoop-multibranch/job/PR-402/1/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 1361 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-402/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 40 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 22 Maven dependency ordering for branch
+1 mvninstall 1033 trunk passed
+1 compile 1013 trunk passed
+1 checkstyle 153 trunk passed
+1 mvnsite 128 trunk passed
+1 shadedclient 956 branch has no errors when building and testing our client artifacts.
+1 javadoc 91 trunk passed
0 spotbugs 76 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 190 trunk passed
_ Patch Compile Tests _
0 mvndep 23 Maven dependency ordering for patch
+1 mvninstall 77 the patch passed
+1 compile 968 the patch passed
-1 javac 968 root generated 1 new + 1476 unchanged - 0 fixed = 1477 total (was 1476)
-0 checkstyle 146 root: The patch generated 10 new + 854 unchanged - 2 fixed = 864 total (was 856)
+1 mvnsite 113 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 669 patch has no errors when building and testing our client artifacts.
+1 javadoc 95 the patch passed
-1 findbugs 127 hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-1 findbugs 90 hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 unit 532 hadoop-common in the patch passed.
+1 unit 335 hadoop-mapreduce-client-core in the patch passed.
-1 asflicense 48 The patch generated 2 ASF License warnings.
6835
Reason Tests
FindBugs module:hadoop-common-project/hadoop-common
instanceof will always return true for all non-null values in org.apache.hadoop.io.SequenceFile$Writer.abort(), since all org.apache.hadoop.fs.FSDataOutputStream are instances of org.apache.hadoop.fs.common.Abortable At SequenceFile.java:for all non-null values in org.apache.hadoop.io.SequenceFile$Writer.abort(), since all org.apache.hadoop.fs.FSDataOutputStream are instances of org.apache.hadoop.fs.common.Abortable At SequenceFile.java:[line 881]
FindBugs module:hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
instanceof will always return false in org.apache.hadoop.mapred.ReduceTask.runOldReducer(JobConf, TaskUmbilicalProtocol, Task$TaskReporter, RawKeyValueIterator, RawComparator, Class, Class), since a org.apache.hadoop.mapred.ReduceTask$OldTrackingRecordWriter<OUTKEY,OUTVALUE> can't be a org.apache.hadoop.fs.common.Abortable At ReduceTask.java:in org.apache.hadoop.mapred.ReduceTask.runOldReducer(JobConf, TaskUmbilicalProtocol, Task$TaskReporter, RawKeyValueIterator, RawComparator, Class, Class), since a org.apache.hadoop.mapred.ReduceTask$OldTrackingRecordWriter<OUTKEY,OUTVALUE> can't be a org.apache.hadoop.fs.common.Abortable At ReduceTask.java:[line 461]
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-402/2/artifact/out/Dockerfile
GITHUB PR #402
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 264b7516c146 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / c7c7a88
Default Java 1.8.0_212
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-402/2/artifact/out/diff-compile-javac-root.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-402/2/artifact/out/diff-checkstyle-root.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-402/2/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-402/2/artifact/out/new-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.html
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-402/2/testReport/
asflicense https://builds.apache.org/job/hadoop-multibranch/job/PR-402/2/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 1645 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-402/2/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 40 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 22 Maven dependency ordering for branch
+1 mvninstall 1083 trunk passed
+1 compile 1072 trunk passed
+1 checkstyle 146 trunk passed
+1 mvnsite 125 trunk passed
+1 shadedclient 975 branch has no errors when building and testing our client artifacts.
+1 javadoc 104 trunk passed
0 spotbugs 82 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 204 trunk passed
_ Patch Compile Tests _
0 mvndep 24 Maven dependency ordering for patch
+1 mvninstall 78 the patch passed
+1 compile 1020 the patch passed
-1 javac 1020 root generated 1 new + 1476 unchanged - 0 fixed = 1477 total (was 1476)
-0 checkstyle 148 root: The patch generated 10 new + 854 unchanged - 2 fixed = 864 total (was 856)
+1 mvnsite 122 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 678 patch has no errors when building and testing our client artifacts.
+1 javadoc 98 the patch passed
-1 findbugs 136 hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-1 findbugs 95 hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
-1 unit 532 hadoop-common in the patch failed.
+1 unit 338 hadoop-mapreduce-client-core in the patch passed.
-1 asflicense 52 The patch generated 2 ASF License warnings.
7097
Reason Tests
FindBugs module:hadoop-common-project/hadoop-common
instanceof will always return true for all non-null values in org.apache.hadoop.io.SequenceFile$Writer.abort(), since all org.apache.hadoop.fs.FSDataOutputStream are instances of org.apache.hadoop.fs.common.Abortable At SequenceFile.java:for all non-null values in org.apache.hadoop.io.SequenceFile$Writer.abort(), since all org.apache.hadoop.fs.FSDataOutputStream are instances of org.apache.hadoop.fs.common.Abortable At SequenceFile.java:[line 881]
FindBugs module:hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
instanceof will always return false in org.apache.hadoop.mapred.ReduceTask.runOldReducer(JobConf, TaskUmbilicalProtocol, Task$TaskReporter, RawKeyValueIterator, RawComparator, Class, Class), since a org.apache.hadoop.mapred.ReduceTask$OldTrackingRecordWriter<OUTKEY,OUTVALUE> can't be a org.apache.hadoop.fs.common.Abortable At ReduceTask.java:in org.apache.hadoop.mapred.ReduceTask.runOldReducer(JobConf, TaskUmbilicalProtocol, Task$TaskReporter, RawKeyValueIterator, RawComparator, Class, Class), since a org.apache.hadoop.mapred.ReduceTask$OldTrackingRecordWriter<OUTKEY,OUTVALUE> can't be a org.apache.hadoop.fs.common.Abortable At ReduceTask.java:[line 461]
Failed junit tests hadoop.util.TestReadWriteDiskValidator
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-402/3/artifact/out/Dockerfile
GITHUB PR #402
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 5753f30a6519 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / e872ceb
Default Java 1.8.0_212
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-402/3/artifact/out/diff-compile-javac-root.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-402/3/artifact/out/diff-checkstyle-root.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-402/3/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-402/3/artifact/out/new-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.html
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-402/3/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-402/3/testReport/
asflicense https://builds.apache.org/job/hadoop-multibranch/job/PR-402/3/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 1561 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-402/3/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 62 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 22 Maven dependency ordering for branch
+1 mvninstall 1067 trunk passed
+1 compile 1079 trunk passed
+1 checkstyle 147 trunk passed
+1 mvnsite 110 trunk passed
+1 shadedclient 999 branch has no errors when building and testing our client artifacts.
+1 javadoc 80 trunk passed
0 spotbugs 78 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 192 trunk passed
_ Patch Compile Tests _
0 mvndep 28 Maven dependency ordering for patch
+1 mvninstall 74 the patch passed
+1 compile 1022 the patch passed
-1 javac 1022 root generated 1 new + 1476 unchanged - 0 fixed = 1477 total (was 1476)
-0 checkstyle 140 root: The patch generated 10 new + 854 unchanged - 2 fixed = 864 total (was 856)
+1 mvnsite 106 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 616 patch has no errors when building and testing our client artifacts.
+1 javadoc 82 the patch passed
-1 findbugs 122 hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-1 findbugs 86 hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 unit 546 hadoop-common in the patch passed.
-1 unit 27 hadoop-mapreduce-client-core in the patch failed.
-1 asflicense 40 The patch generated 2 ASF License warnings.
6640
Reason Tests
FindBugs module:hadoop-common-project/hadoop-common
instanceof will always return true for all non-null values in org.apache.hadoop.io.SequenceFile$Writer.abort(), since all org.apache.hadoop.fs.FSDataOutputStream are instances of org.apache.hadoop.fs.common.Abortable At SequenceFile.java:for all non-null values in org.apache.hadoop.io.SequenceFile$Writer.abort(), since all org.apache.hadoop.fs.FSDataOutputStream are instances of org.apache.hadoop.fs.common.Abortable At SequenceFile.java:[line 881]
FindBugs module:hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
instanceof will always return false in org.apache.hadoop.mapred.ReduceTask.runOldReducer(JobConf, TaskUmbilicalProtocol, Task$TaskReporter, RawKeyValueIterator, RawComparator, Class, Class), since a org.apache.hadoop.mapred.ReduceTask$OldTrackingRecordWriter<OUTKEY,OUTVALUE> can't be a org.apache.hadoop.fs.common.Abortable At ReduceTask.java:in org.apache.hadoop.mapred.ReduceTask.runOldReducer(JobConf, TaskUmbilicalProtocol, Task$TaskReporter, RawKeyValueIterator, RawComparator, Class, Class), since a org.apache.hadoop.mapred.ReduceTask$OldTrackingRecordWriter<OUTKEY,OUTVALUE> can't be a org.apache.hadoop.fs.common.Abortable At ReduceTask.java:[line 461]
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-402/4/artifact/out/Dockerfile
GITHUB PR #402
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 59266f8ea938 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 00b5a27
Default Java 1.8.0_222
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-402/4/artifact/out/diff-compile-javac-root.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-402/4/artifact/out/diff-checkstyle-root.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-402/4/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-402/4/artifact/out/new-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.html
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-402/4/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-402/4/testReport/
asflicense https://builds.apache.org/job/hadoop-multibranch/job/PR-402/4/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 1389 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-402/4/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 67 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 22 Maven dependency ordering for branch
+1 mvninstall 1096 trunk passed
+1 compile 1234 trunk passed
+1 checkstyle 147 trunk passed
+1 mvnsite 108 trunk passed
+1 shadedclient 972 branch has no errors when building and testing our client artifacts.
+1 javadoc 82 trunk passed
0 spotbugs 75 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 199 trunk passed
_ Patch Compile Tests _
0 mvndep 24 Maven dependency ordering for patch
+1 mvninstall 79 the patch passed
+1 compile 1193 the patch passed
-1 javac 1193 root generated 1 new + 1469 unchanged - 0 fixed = 1470 total (was 1469)
-0 checkstyle 141 root: The patch generated 10 new + 854 unchanged - 2 fixed = 864 total (was 856)
+1 mvnsite 106 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 632 patch has no errors when building and testing our client artifacts.
+1 javadoc 87 the patch passed
-1 findbugs 130 hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-1 findbugs 81 hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 unit 540 hadoop-common in the patch passed.
+1 unit 336 hadoop-mapreduce-client-core in the patch passed.
-1 asflicense 49 The patch generated 2 ASF License warnings.
7331
Reason Tests
FindBugs module:hadoop-common-project/hadoop-common
instanceof will always return true for all non-null values in org.apache.hadoop.io.SequenceFile$Writer.abort(), since all org.apache.hadoop.fs.FSDataOutputStream are instances of org.apache.hadoop.fs.common.Abortable At SequenceFile.java:for all non-null values in org.apache.hadoop.io.SequenceFile$Writer.abort(), since all org.apache.hadoop.fs.FSDataOutputStream are instances of org.apache.hadoop.fs.common.Abortable At SequenceFile.java:[line 881]
FindBugs module:hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
instanceof will always return false in org.apache.hadoop.mapred.ReduceTask.runOldReducer(JobConf, TaskUmbilicalProtocol, Task$TaskReporter, RawKeyValueIterator, RawComparator, Class, Class), since a org.apache.hadoop.mapred.ReduceTask$OldTrackingRecordWriter<OUTKEY,OUTVAL 8000 UE> can't be a org.apache.hadoop.fs.common.Abortable At ReduceTask.java:in org.apache.hadoop.mapred.ReduceTask.runOldReducer(JobConf, TaskUmbilicalProtocol, Task$TaskReporter, RawKeyValueIterator, RawComparator, Class, Class), since a org.apache.hadoop.mapred.ReduceTask$OldTrackingRecordWriter<OUTKEY,OUTVALUE> can't be a org.apache.hadoop.fs.common.Abortable At ReduceTask.java:[line 461]
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-402/5/artifact/out/Dockerfile
GITHUB PR #402
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 13ad574378fb 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / e356e4f
Default Java 1.8.0_222
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-402/5/artifact/out/diff-compile-javac-root.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-402/5/artifact/out/diff-checkstyle-root.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-402/5/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-402/5/artifact/out/new-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.html
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-402/5/testReport/
asflicense https://builds.apache.org/job/hadoop-multibranch/job/PR-402/5/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 1572 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-402/5/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 42 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 23 Maven dependency ordering for branch
+1 mvninstall 1053 trunk passed
+1 compile 1066 trunk passed
+1 checkstyle 142 trunk passed
+1 mvnsite 103 trunk passed
+1 shadedclient 925 branch has no errors when building and testing our client artifacts.
+1 javadoc 86 trunk passed
0 spotbugs 80 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 199 trunk passed
_ Patch Compile Tests _
0 mvndep 24 Maven dependency ordering for patch
+1 mvninstall 83 the patch passed
+1 compile 1112 the patch passed
-1 javac 1112 root generated 1 new + 1469 unchanged - 0 fixed = 1470 total (was 1469)
-0 checkstyle 147 root: The patch generated 10 new + 854 unchanged - 2 fixed = 864 total (was 856)
+1 mvnsite 112 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 666 patch has no errors when building and testing our client artifacts.
+1 javadoc 82 the patch passed
-1 findbugs 127 hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-1 findbugs 83 hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 unit 532 hadoop-common in the patch passed.
+1 unit 319 hadoop-mapreduce-client-core in the patch passed.
-1 asflicense 41 The patch generated 2 ASF License warnings.
6971
Reason Tests
FindBugs module:hadoop-common-project/hadoop-common
instanceof will always return true for all non-null values in org.apache.hadoop.io.SequenceFile$Writer.abort(), since all org.apache.hadoop.fs.FSDataOutputStream are instances of org.apache.hadoop.fs.common.Abortable At SequenceFile.java:for all non-null values in org.apache.hadoop.io.SequenceFile$Writer.abort(), since all org.apache.hadoop.fs.FSDataOutputStream are instances of org.apache.hadoop.fs.common.Abortable At SequenceFile.java:[line 881]
FindBugs module:hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
instanceof will always return false in org.apache.hadoop.mapred.ReduceTask.runOldReducer(JobConf, TaskUmbilicalProtocol, Task$TaskReporter, RawKeyValueIterator, RawComparator, Class, Class), since a org.apache.hadoop.mapred.ReduceTask$OldTrackingRecordWriter<OUTKEY,OUTVALUE> can't be a org.apache.hadoop.fs.common.Abortable At ReduceTask.java:in org.apache.hadoop.mapred.ReduceTask.runOldReducer(JobConf, TaskUmbilicalProtocol, Task$TaskReporter, RawKeyValueIterator, RawComparator, Class, Class), since a org.apache.hadoop.mapred.ReduceTask$OldTrackingRecordWriter<OUTKEY,OUTVALUE> can't be a org.apache.hadoop.fs.common.Abortable At ReduceTask.java:[line 461]
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-402/6/artifact/out/Dockerfile
GITHUB PR #402
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux c973e0cd2bd8 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 094d736
Default Java 1.8.0_222
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-402/6/artifact/out/diff-compile-javac-root.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-402/6/artifact/out/diff-checkstyle-root.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-402/6/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-402/6/artifact/out/new-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.html
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-402/6/testReport/
asflicense https://builds.apache.org/job/hadoop-multibranch/job/PR-402/6/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 1664 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-402/6/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 40 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 21 Maven dependency ordering for branch
+1 mvninstall 1090 trunk passed
+1 compile 1095 trunk passed
+1 checkstyle 144 trunk passed
+1 mvnsite 109 trunk passed
+1 shadedclient 946 branch has no errors when building and testing our client artifacts.
+1 javadoc 97 trunk passed
0 spotbugs 73 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 197 trunk passed
_ Patch Compile Tests _
0 mvndep 20 Maven dependency ordering for patch
+1 mvninstall 77 the patch passed
+1 compile 1025 the patch passed
-1 javac 1025 root generated 1 new + 1469 unchanged - 0 fixed = 1470 total (was 1469)
-0 checkstyle 148 root: The patch generated 10 new + 854 unchanged - 2 fixed = 864 total (was 856)
+1 mvnsite 107 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 641 patch has no errors when building and testing our client artifacts.
+1 javadoc 84 the patch passed
-1 findbugs 125 hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-1 findbugs 28 hadoop-mapreduce-client-core in the patch failed.
_ Other Tests _
-1 unit 502 hadoop-common in the patch failed.
-1 unit 29 hadoop-mapreduce-client-core in the patch failed.
-1 asflicense 41 The patch generated 2 ASF License warnings.
6554
Reason Tests
FindBugs module:hadoop-common-project/hadoop-common
instanceof will always return true for all non-null values in org.apache.hadoop.io.SequenceFile$Writer.abort(), since all org.apache.hadoop.fs.FSDataOutputStream are instances of org.apache.hadoop.fs.common.Abortable At SequenceFile.java:for all non-null values in org.apache.hadoop.io.SequenceFile$Writer.abort(), since all org.apache.hadoop.fs.FSDataOutputStream are instances of org.apache.hadoop.fs.common.Abortable At SequenceFile.java:[line 881]
Failed junit tests hadoop.util.TestDiskChecker
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-402/7/artifact/out/Dockerfile
GITHUB PR #402
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 2b850bacb076 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 69ddb36
Default Java 1.8.0_222
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-402/7/artifact/out/diff-compile-javac-root.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-402/7/artifact/out/diff-checkstyle-root.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-402/7/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-402/7/artifact/out/patch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-402/7/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-402/7/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-402/7/testReport/
asflicense https://builds.apache.org/job/hadoop-multibranch/job/PR-402/7/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 1605 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-402/7/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 69 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 27 Maven dependency ordering for branch
+1 mvninstall 1013 trunk passed
+1 compile 977 trunk passed
+1 checkstyle 157 trunk passed
+1 mvnsite 132 trunk passed
+1 shadedclient 1016 branch has no errors when building and testing our client artifacts.
+1 javadoc 104 trunk passed
0 spotbugs 80 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 199 trunk passed
_ Patch Compile Tests _
0 mvndep 23 Maven dependency ordering for patch
+1 mvninstall 77 the patch passed
+1 compile 925 the patch passed
-1 javac 925 root generated 1 new + 1469 unchanged - 0 fixed = 1470 total (was 1469)
-0 checkstyle 162 root: The patch generated 10 new + 854 unchanged - 2 fixed = 864 total (was 856)
+1 mvnsite 128 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 689 patch has no errors when building and testing our client artifacts.
+1 javadoc 106 the patch passed
-1 findbugs 128 hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-1 findbugs 89 hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 unit 580 hadoop-common in the patch passed.
+1 unit 333 hadoop-mapreduce-client-core in the patch passed.
-1 asflicense 53 The patch generated 2 ASF License warnings.
6994
Reason Tests
FindBugs module:hadoop-common-project/hadoop-common
instanceof will always return true for all non-null values in org.apache.hadoop.io.SequenceFile$Writer.abort(), since all org.apache.hadoop.fs.FSDataOutputStream are instances of org.apache.hadoop.fs.common.Abortable At SequenceFile.java:for all non-null values in org.apache.hadoop.io.SequenceFile$Writer.abort(), since all org.apache.hadoop.fs.FSDataOutputStream are instances of org.apache.hadoop.fs.common.Abortable At SequenceFile.java:[line 881]
FindBugs module:hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
instanceof will always return false in org.apache.hadoop.mapred.ReduceTask.runOldReducer(JobConf, TaskUmbilicalProtocol, Task$TaskReporter, RawKeyValueIterator, RawComparator, Class, Class), since a org.apache.hadoop.mapred.ReduceTask$OldTrackingRecordWriter<OUTKEY,OUTVALUE> can't be a org.apache.hadoop.fs.common.Abortable At ReduceTask.java:in org.apache.hadoop.mapred.ReduceTask.runOldReducer(JobConf, TaskUmbilicalProtocol, Task$TaskReporter, RawKeyValueIterator, RawComparator, Class, Class), since a org.apache.hadoop.mapred.ReduceTask$OldTrackingRecordWriter<OUTKEY,OUTVALUE> can't be a org.apache.hadoop.fs.common.Abortable At ReduceTask.java:[line 461]
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-402/8/artifact/out/Dockerfile
GITHUB PR #402
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 37a2cf466d46 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 3329257
Default Java 1.8.0_222
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-402/8/artifact/out/diff-compile-javac-root.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-402/8/artifact/out/diff-checkstyle-root.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-402/8/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-402/8/artifact/out/new-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.html
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-402/8/testReport/
asflicense https://builds.apache.org/job/hadoop-multibranch/job/PR-402/8/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 1608 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-402/8/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10 8000 .0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 patch 11 #402 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.
Subsystem Report/Notes
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-402/9/console
versions git=2.17.1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
@xinyuiscool
SAMZA-1553: Add log4j for latest Kafka build
5238aaa 
Add it so Samza compiles with the latest kafka.

Author: xiliu <xiliu@xiliu-ld1.linkedin.biz>

Reviewers: Boris Shkolnik <sborya@gmail.com>

Closes apache#402 from xinyuiscool/SAMZA-1553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bschell @hadoop-yetus
0