8000 Fix the bug that calling the unregisterServiceInstance method in the DubboBootstrap#destroy method does not work by BurningCN · Pull Request #7965 · apache/dubbo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix the bug that calling the unregisterServiceInstance method in the DubboBootstrap#destroy method does not work #7965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2021
Merged

Fix the bug that calling the unregisterServiceInstance method in the DubboBootstrap#destroy method does not work #7965

merged 1 commit into from
Jun 3, 2021

Conversation

BurningCN
Copy link
Member
@BurningCN BurningCN commented Jun 3, 2021 •
edited
Loading

for issue #7960

@codecov-commenter
Copy link
codecov-commenter commented Jun 3, 2021 •
edited
Loading

Codecov Report

Merging #7965 (851fc1c) into master (e845e16) will increase coverage by 1.53%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7965      +/-   ##
============================================
+ Coverage     59.28%   60.81%   +1.53%     
+ Complexity      529      491      -38     
============================================
  Files          1077     1089      +12     
  Lines         43565    43877     +312     
  Branches       6368     6412      +44     
============================================
+ Hits          25826    26685     +859     
+ Misses        14879    14223     -656     
- Partials       2860     2969     +109
Impacted Files Coverage Δ
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 54.41% <100.00%> (+10.71%) ⬆️
...org/apache/dubbo/remoting/zookeeper/EventType.java 0.00% <0.00%> (-61.91%) ⬇️
.../configcenter/support/zookeeper/CacheListener.java 28.57% <0.00%> (-27.68%) ⬇️
.../dubbo/remoting/transport/MultiMessageHandler.java 80.00% <0.00%> (-20.00%) ⬇️
...bo/rpc/cluster/support/FailbackClusterInvoker.java 52.45% <0.00%> (-18.04%) ⬇️
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 76.92% <0.00%> (-15.39%) ⬇️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) ⬇️
...va/org/apache/dubbo/rpc/support/ProtocolUtils.java 61.53% <0.00%> (-8.03%) ⬇️
...bbo/config/bootstrap/builders/ConsumerBuilder.java 93.10% <0.00%> (-6.90%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) ⬇️
... and 163 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e845e16...851fc1c. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 9f6b536 into apache:master Jun 3, 2021
@wangchengming666 wangchengming666 mentioned this pull request Sep 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BurningCN @codecov-commenter @AlbumenJ
0