8000 Add generics to avoid forced conversion by BurningCN · Pull Request #7964 · apache/dubbo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add generics to avoid forced conversion #7964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2021
Merged

Add generics to avoid forced conversion #7964

merged 1 commit into from
Jun 4, 2021

Conversation

BurningCN
Copy link
Member

What is the purpose of the change

Add generics to avoid forced conversion

@codecov-commenter
Copy link
codecov-commenter commented Jun 3, 2021 •
edited
Loading

Codecov Report

Merging #7964 (3b4b4cd) into master (e845e16) will increase coverage by 1.55%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7964      +/-   ##
============================================
+ Coverage     59.28%   60.84%   +1.55%     
+ Complexity      529      491      -38     
============================================
  Files          1077     1089      +12     
  Lines         43565    43877     +312     
  Branches       6368     6412      +44     
============================================
+ Hits          25826    26695     +869     
+ Misses        14879    14214     -665     
- Partials       2860     2968     +108
Impacted Files Coverage Δ
...bbo/common/bytecode/CustomizedLoaderClassPath.java 28.00% <50.00%> (ø)
...org/apache/dubbo/remoting/zookeeper/EventType.java 0.00% <0.00%> (-61.91%) ⬇️
.../configcenter/support/zookeeper/CacheListener.java 28.57% <0.00%> (-27.68%) ⬇️
.../dubbo/remoting/transport/MultiMessageHandler.java 80.00% <0.00%> (-20.00%) ⬇️
...bo/rpc/cluster/support/FailbackClusterInvoker.java 52.45% <0.00%> (-18.04%) ⬇️
...va/org/apache/dubbo/rpc/support/ProtocolUtils.java 61.53% <0.00%> (-8.03%) ⬇️
...bbo/config/bootstrap/builders/ConsumerBuilder.java 93.10% <0.00%> (-6.90%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 80.34% <0.00%> (-6.84%) ⬇️
...apache/dubbo/rpc/cluster/support/ClusterUtils.java 60.00% <0.00%> (-6.04%) ⬇️
...apache/dubbo/rpc/protocol/injvm/InjvmProtocol.java 72.22% <0.00%> (-5.56%) ⬇️
... and 152 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e845e16...3b4b4cd. Read the comment docs.

chickenlj
chickenlj approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor
@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chickenlj chickenlj merged commit 388d2bd into apache:master Jun 4, 2021
@chickenlj chickenlj added this to the 2.7.12 milestone Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chickenlj chickenlj chickenlj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7.12
Development

Successfully merging this pull request may close these issues.
3 participants
@BurningCN @codecov-commenter @chickenlj
0