10000 support dynamic update method concurrency by yanglimingcn · Pull Request #2923 · apache/brpc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

support dynamic update method concurrency #2923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2025
Merged

support dynamic update method concurrency #2923

merged 1 commit into from
Mar 30, 2025

Conversation

yanglimingcn
Copy link
Contributor
@yanglimingcn yanglimingcn commented Mar 21, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: #2873

目前只实现了ConstantConcurrencyLimiter的动态修改。

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):

Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

wwbmmm
wwbmmm reviewed Mar 21, 2025
View reviewed changes
@yanglimingcn yanglimingcn force-pushed the feature/method_concurrency_online_update branch 2 times, most recently from 616428b to bdd0238 Compare March 24, 2025 12:02
wwbmmm
wwbmmm reviewed Mar 25, 2025
View reviewed changes
@yanglimingcn yanglimingcn force-pushed the feature/method_concurrency_online_update branch from bdd0238 to 7903e9a Compare March 25, 2025 09:27
@wwbmmm
Copy link
Contributor
wwbmmm commented Mar 26, 2025

LGTM

chenBright
chenBright approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor
@chenBright chenBright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我们这边也是类似的实现。

LGTM

@zyearn zyearn merged commit bf88565 into apache:master Mar 30, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwbmmm wwbmmm wwbmmm left review comments

@chenBright chenBright chenBright approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yanglimingcn @wwbmmm @chenBright @zyearn
0