Return Non-Generic Errors from HttpStore #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfde9d8 to
72f5d49
Compare
… relevant crate::Error using RetryError::source. Allows for better error handling of HTTP statuses, and makes it consistent with how the S3/Azure/GCP clients handles RetryError.
72f5d49 to
9f2a272
Compare
tustvold
reviewed
May 16, 2025
…into align-retryerror-usage-http
tustvold
approved these changes
May 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #365.
Rationale for this change
Allows for better error handling of HTTP statuses, and makes it consistent with how the S3/Azure/GCP clients handles RetryError.
What changes are included in this PR?
Adjust implementation of
impl From<http::client::Error> for crate::Errorto use RetryError::error when possible.Are there any user-facing changes?
Most RetryError cases just returned
crate::Error::GenericErrorbefore, now they'll return the crate::Error that matches the RetryError