8000 chore(configs/config.yaml): Change `api_url` to `api_base_url` by kwsxing · Pull Request #1357 · apache/answer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore(configs/config.yaml): Change api_url to api_base_url #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(configs/config.yaml): Change api_url to api_base_url #1357

wants to merge 1 commit into from

Conversation

kwsxing
Copy link
@kwsxing kwsxing commented Jun 17, 2025 •
edited
Loading

In configs/config.yaml

answer/configs/config.yaml

Lines 39 to 42 in 530812f

ui:
public_url: '/'
api_url: '/'
base_url: ''

But the name is different in internal/base/server/config.go

answer/internal/base/server/config.go

Lines 28 to 31 in 530812f

type UI struct {
BaseURL string `json:"base_url" mapstructure:"base_url" yaml:"base_url"`
APIBaseURL string `json:"api_base_url" mapstructure:"api_base_url" yaml:"api_base_url"`
}

So I changed the api_url to api_base_url and moved it below base_url (APIBaseURL is below BaseURL).

@LinkinStars LinkinStars self-requested a review June 17, 2025 11:19
@LinkinStars LinkinStars self-assigned this Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkinStars LinkinStars Awaiting requested review from LinkinStars

Assignees

@LinkinStars LinkinStars

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwsxing @LinkinStars
0