8000 TO prevents assigning ORG servers to topology-based delivery services · Issue #6392 · apache/trafficcontrol · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

TO prevents assigning ORG servers to topology-based delivery services #6392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rawlinp opened this issue Dec 2, 2021 · 3 comments · Fixed by #6408
Closed

TO prevents assigning ORG servers to topology-based delivery services #6392

rawlinp opened this issue Dec 2, 2021 · 3 comments · Fixed by #6408
Assignees
Labels
bug something isn't working as intended high impact impacts the basic function, deployment, or operation of a CDN low difficulty the estimated level of effort to resolve this issue is low Traffic Ops related to Traffic Ops

Comments

@rawlinp
Copy link
Contributor
rawlinp commented Dec 2, 2021

This Bug Report affects these Traffic Control components:

  • Traffic Ops

Current behavior:

If you attempt to assign ORG servers to a topology-based delivery service (if you are setting it up for MSO, for instance), and it has pre-existing DS-server EDGE assignments, TO returns the following error:

this server assignment leaves Active Delivery Service #11069 without any 'ONLINE' or 'REPORTED' servers

Expected behavior:

TO should allow you to assign ORG servers to a topology-based DS that has no DS-server EDGE assignments.

Steps to reproduce:

In TP, go to a topology-based delivery service that doesn't have any pre-existing EDGE server assignments, then More > Manage Servers > More > Assign ORG Servers > select an ORG server to assign > Submit

@rawlinp rawlinp added bug something isn't working as intended Traffic Ops related to Traffic Ops medium impact impacts a significant portion of a CDN, or has the potential to do so low difficulty the estimated level of effort to resolve this issue is low labels Dec 2, 2021
@rawlinp
Copy link
Contributor Author
rawlinp commented Dec 2, 2021

FYI I labelled this as medium impact since it has a workaround but could be very tedious if you had to use the workaround for any more than just a few delivery services.

@mitchell852
Copy link
Member
mitchell852 8000 commented Dec 3, 2021

it seems it has another "impact". we're seeing a bug where same message:

this server assignment leaves Active Delivery Service #X without any 'ONLINE' or 'REPORTED' servers

when trying to "offline" a server in a cache group that is used by a topology used by an MSO ds thus preventing us to offline a server that needs to be offlined. enough to bump it to "high impact" @rawlinp ? then again, this appears to have a work-around too...

@rawlinp rawlinp added high impact impacts the basic function, deployment, or operation of a CDN and removed medium impact impacts a significant portion of a CDN, or has the potential to do so labels Dec 3, 2021
@rawlinp
Copy link
Contributor Author
rawlinp commented Dec 3, 2021

Yeah, I agree, we should be able to offline servers for MSO topology-based DSes as well. Since that is a much more common use case, I think that warrants high impact.

rawlinp added a commit to rawlinp/trafficcontrol that referenced this issue Dec 6, 2021
In order to prevent accidental ouages, TO currently has validation which
prevents things like deleting the last server that is assigned to an
active delivery service. However, this validation ignored the fact that
delivery services can now be assigned to a topology instead of using DSS
assignments. This prevents a number of actually valid things, such as
safely setting caches to ADMIN_DOWN, assigning MSO servers to
topology-based DSes, and removing legacy DSS EDGE assignments from
topology-based DSes. This fixes that validation in order to take
topology-based DSes into account.

Closes: apache#6392
zrhoffman pushed a commit that referenced this issue Dec 6, 2021
…6408)

* Take topology-based DSes into account when checking DSS assignments

In order to prevent accidental ouages, TO currently has validation which
prevents things like deleting the last server that is assigned to an
active delivery service. However, this validation ignored the fact that
delivery services can now be assigned to a topology instead of using DSS
assignments. This prevents a number of actually valid things, such as
safely setting caches to ADMIN_DOWN, assigning MSO servers to
topology-based DSes, and removing legacy DSS EDGE assignments from
topology-based DSes. This fixes that validation in order to take
topology-based DSes into account.

Closes: #6392

* Fix GROUP BY

* Add TO API test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended high impact impacts the basic function, deployment, or operation of a CDN low difficulty the estimated level of effort to resolve this issue is low Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
0